This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Checkout PR head sha #1626
Closed
Checkout PR head sha #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Didn't this cause problems with Chromatic? |
amacneil
force-pushed
the
adrian/pr-head-sha
branch
from
54668a3
to
6e9e8de
Compare
|
This PR just changes from using ref to sha, so I think chromatic will be happy. The issues with chromatic stem from using the PR merge commit (which I tested removing in #1625 - and it did seem to cause chromatic to get confused about where the base is). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
None
Description
Alternative to #1625. Instead of checking out the merge commit, check out the PR head (specified by
shainstead ofrefas directed by the actions/checkout docs).