Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream version of no-meaningless-void-operator #35

Merged
merged 1 commit into from Sep 9, 2021

Conversation

jtbandes
Copy link
Member

@jtbandes jtbandes commented Sep 9, 2021

Public-Facing Changes
Removes @foxglove/no-meaningless-void-operator, because this rule has been upstreamed as @typescript-eslint/no-meaningless-void-operator (typescript-eslint/typescript-eslint#3641), as of @typescript-eslint/eslint-plugin version 4.31.0.

Comment on lines +35 to +36
"@typescript-eslint/eslint-plugin": "^4.31.0",
"@typescript-eslint/parser": "^4.31.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tempted to change these to peerDependencies, so that downstream users will receive appropriate warnings if an older version is installed. However, I recognize that some may use this plugin for pure JS code and don't need the TypeScript related plugins. @amacneil is there a more appropriate way to ensure the user will always import a new enough version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - same thing applies for typescript itself. I opted for just not including these. This situation with a new rule is unique though.

The only option here would be to split out the packages so they can have separate deps, but that seems annoying/overkill. Otherwise we could list it as an optionalPeerDep which I think only yarn supports, and I’m not sure is even enforced anywhere.

Given that we are the primary users of this package and we tend to keep our deps up to date, I’d be inclined to just leave things as is and put a PSA in slack (mostly for all @jhurliman’s packages).

@jtbandes jtbandes merged commit ea7d6f9 into main Sep 9, 2021
@jtbandes jtbandes deleted the jacob/upstream-void branch September 9, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants