Use upstream version of no-meaningless-void-operator (#35)

**Public-Facing Changes**
Removes `@foxglove/no-meaningless-void-operator`, because this rule has been upstreamed as `@typescript-eslint/no-meaningless-void-operator` (typescript-eslint/typescript-eslint#3641), as of `@typescript-eslint/eslint-plugin` version 4.31.0.

configs/typescript.example.ts

@@ -28,5 +28,7 @@ void (async () => {
   wut == null ? 0 : 1; // allowed
 };
 
+void undefined; // eslint-disable-line @typescript-eslint/no-meaningless-void-operator
+
 // keep isolatedModules happy
 export default {};

configs/typescript.js

@@ -8,7 +8,10 @@ module.exports = {
   rules: {
     // Avoid #member syntax for performance
     "@foxglove/no-private-identifier": "error",
-    "@foxglove/no-meaningless-void-operator": ["error", { checkNever: true }],
+    "@typescript-eslint/no-meaningless-void-operator": [
+      "error",
+      { checkNever: true },
+    ],
     "@foxglove/no-boolean-parameters": "error",
 
     // `<T>x` style assertions are not compatible with JSX code,

index.js

@@ -3,7 +3,6 @@ module.exports = {
     "license-header": require("./rules/license-header"),
     "no-private-identifier": require("./rules/no-private-identifier"),
     "strict-equality": require("./rules/strict-equality"),
-    "no-meaningless-void-operator": require("./rules/no-meaningless-void-operator"),
     "no-return-promise-resolve": require("./rules/no-return-promise-resolve"),
     "no-boolean-parameters": require("./rules/no-boolean-parameters"),
   },

package.json

@@ -32,8 +32,8 @@
     "@foxglove/eslint-plugin": "file:.",
     "@foxglove/tsconfig": "1.0.0",
     "@types/jest": "^27",
-    "@typescript-eslint/eslint-plugin": "^4",
-    "@typescript-eslint/parser": "^4",
+    "@typescript-eslint/eslint-plugin": "^4.31.0",
+    "@typescript-eslint/parser": "^4.31.0",
     "eslint-plugin-jest": "^24",
     "eslint-plugin-react": "^7",
     "eslint-plugin-react-hooks": "^4",

rules/README.md

@@ -28,55 +28,6 @@ const draw = ({ immediate }: { immediate?: boolean }) => {};
 const draw = ({ immediate = false }: { immediate: boolean }) => {};
 ```
 
-### [`@foxglove/no-meaningless-void-operator`](./no-meaningless-void-operator.js) 💭 🔧
-
-Disallow the `void` operator when its argument is already of type `void` or `undefined`.
-
-The `void` operator is a useful tool to convey the programmer's intent to discard a value. For example, it is recommended as one way of suppressing [`@typescript-eslint/no-floating-promises`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-floating-promises.md) instead of adding `.catch()` to a promise.
-
-This rule helps an author catch API changes where previously a value was being discarded at a call site, but the callee changed so it no longer returns a value. When combined with [no-unused-expressions](https://eslint.org/docs/rules/no-unused-expressions), it also helps _readers_ of the code by ensuring consistency: a statement that looks like `void foo();` is **always** discarding a return value, and a statement that looks like `foo();` is **never** discarding a return value.
-
-Examples of **incorrect** code for this rule:
-
-```ts
-void (() => {})();
-
-function foo() {}
-void foo();
-```
-
-Examples of **correct** code for this rule:
-
-```ts
-(() => {})();
-
-function foo() {}
-foo(); // nothing to discard
-
-function bar(x: number) {
-  void x; // discarding a number
-  return 2;
-}
-void bar(); // discarding a number
-```
-
-### Options
-
-This rule accepts a single object option with the following default configuration:
-
-```json
-{
-  "@typescript-eslint/no-meaningless-void-operator": [
-    "error",
-    {
-      "checkNever": false
-    }
-  ]
-}
-```
-
-- `checkNever: true` will suggest removing `void` when the argument has type `never`.
-
 ### [`@foxglove/no-return-promise-resolve`](./no-return-promise-resolve.js) 🔧
 
 Disallow returning `Promise.resolve(...)` or `Promise.reject(...)` inside an async function. This is redundant since an async function will always return a Promise — use `return` or `throw` directly instead.