Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump svgo from 1.3.2 to 2.0.1 #12731

Merged
merged 3 commits into from Feb 19, 2021
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 18, 2021

Bumps svgo from 1.3.2 to 2.0.1.

Release notes

Sourced from svgo's releases.

v2.0.1

Thanks to @sk- @Brooooooklyn @strarsis @AlpayY @TrySound

v2.0.0

Happy to introduce SVGO 2.0. Package size was drastically reduced. Configuration is heavily simplified. Node 10.13+ is required.

Config changes

Since early versions plugins configuration was affected by yaml syntax. Though it was not practial in json or javascript for writing and for internal work.

plugins:
    - removeViewBox: true
    - removeAttr:
        attrs: '(fill|stroke)'
{
  plugins: [
    {
      removeViewBox: true
    },
    {
      removeAttr: {
        attrs: '(fill|stroke)'
      }
    }
  ]
}

In the new version plugins configuration is closer to internal representation.

{
  plugins: [
    {
      name: 'removeViewBox'
    },
    {
      name: 'removeAttr',
</tr></table> 

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by trysound, a new releaser for svgo since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [svgo](https://github.com/svg/svgo) from 1.3.2 to 2.0.1.
- [Release notes](https://github.com/svg/svgo/releases)
- [Changelog](https://github.com/svg/svgo/blob/master/CHANGELOG-old.md)
- [Commits](svg/svgo@v1.3.2...v2.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested review from a team, nickytonline and vaidehijoshi and removed request for a team February 18, 2021 15:48
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 18, 2021
@rhymes
Copy link
Contributor

rhymes commented Feb 19, 2021

Making the necessary changes manually

@rhymes
Copy link
Contributor

rhymes commented Feb 19, 2021

Thanks @TrySound from the speedy help in svg/svgo#1343 (comment) :)

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 19, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 19, 2021

A newer version of svgo exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@@ -71,7 +71,7 @@
"prettier --write --prose-wrap always"
],
"*.svg": [
"svgo --disable=removeViewBox --pretty"
"svgo --pretty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking in with @ludwiczakpawel for this setting. just read the docs, so this no longer works, but do we need this setting still @ludwiczakpawel ? There's a new way to set it I believe @rhymes ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In svgo.config.js

Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that the new config was added. LGTM! 🚀

@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Feb 19, 2021
@nickytonline nickytonline merged commit fc6dfe8 into master Feb 19, 2021
@nickytonline nickytonline deleted the dependabot/npm_and_yarn/svgo-2.0.1 branch February 19, 2021 13:05
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants