Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path intersection was not checking paths with circles #1229

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

sk-
Copy link
Contributor

@sk- sk- commented Mar 9, 2020

As an optimization the path intersection was checking the paths had three or more elements, caliming that otherwise there was nothing to fill. However a semi circle would actually contain 2 points.

Fixes #1048.

This adds a simplified test case for the 2 offending files reported in the issue.

sk- and others added 2 commits March 9, 2020 20:38
As an optimization the path intersection was checking the paths had three or more elements, caliming that otherwise there was nothing to fill. However a semi circle would actually contain 2 points.

Fixes svg#1048.

This adds a simplified test case for the 2 offending files reported in the issue.
@sk-
Copy link
Contributor Author

sk- commented Feb 15, 2021

@TrySound I just rebased this PR.

@TrySound TrySound merged commit c9a3aea into svg:master Feb 17, 2021
@TrySound
Copy link
Member

Thanks @sk-!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--enable=mergePaths breaks file
2 participants