Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file detection for *.SVG files when working with folders #1316

Merged
merged 3 commits into from Feb 18, 2021

Conversation

AlpayY
Copy link
Contributor

@AlpayY AlpayY commented Jan 26, 2021

Currently, files named *.SVG are not being detected under Windows because of the case-sensitivity. This commit includes these in addition to *.svg files.

Currently, files named *.SVG are not being detected under Windows because of the case-sensitivity. This commit includes these in addition to *.svg files.
Copy link

@janmoritz janmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simpler solution would be to include the case sensitivity in the RegEx of regSVGFile = /\.svg$/i; by adding the i.

@AlpayY
Copy link
Contributor Author

AlpayY commented Jan 28, 2021

Great idea! I tried a variation of this idea first, but couldn't get it to work. Your solution is better.

@AlpayY AlpayY marked this pull request as draft January 28, 2021 12:13
@TrySound TrySound marked this pull request as ready for review February 18, 2021 14:47
@TrySound TrySound merged commit 16cc8cf into svg:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants