Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createdAt time for signInWithIdp new users #5260

Merged
merged 1 commit into from Nov 21, 2022
Merged

Conversation

lisajian
Copy link
Contributor

@lisajian lisajian commented Nov 19, 2022

Description

As the title suggests. Should fix #5203.

Scenarios Tested

  • npm test passes
  • Some manual verification (since unit testing this is a little difficult w/o time mocks aside from checking that the createdAt time is present):

Sample Commands

N/A

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Base: 56.27% // Head: 56.27% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f3c2973) compared to base (b2d23b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5260   +/-   ##
=======================================
  Coverage   56.27%   56.27%           
=======================================
  Files         309      309           
  Lines       20819    20820    +1     
  Branches     4224     4224           
=======================================
+ Hits        11715    11716    +1     
  Misses       8092     8092           
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/auth/operations.ts 83.41% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lisajian lisajian merged commit e984a6c into master Nov 21, 2022
@lisajian lisajian deleted the lj-oncreate branch November 21, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authUserOnCreate() in emulator not supplying creationTime in UserRecordMetadata
4 participants