Skip to content

Commit

Permalink
Add createdAt time for signInWithIdp new users (#5260)
Browse files Browse the repository at this point in the history
  • Loading branch information
lisajian committed Nov 21, 2022
1 parent b2d23b6 commit e984a6c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Fix bug where disabling background triggers did nothing. (#5221)
- Fix bug in auth emulator where empty string should throw invalid email instead of missing email. (#3898)
- Fix bug in auth emulator in which createdAt was not set for signInWithIdp new users. (#5203)
4 changes: 3 additions & 1 deletion src/emulator/auth/operations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1608,9 +1608,11 @@ async function signInWithIdp(
oauthExpiresIn: coercePrimitiveToString(response.oauthExpireIn),
};
if (response.isNewUser) {
const timestamp = new Date();
let updates: Partial<UserInfo> = {
...accountUpdates.fields,
lastLoginAt: Date.now().toString(),
createdAt: timestamp.getTime().toString(),
lastLoginAt: timestamp.getTime().toString(),
providerUserInfo: [providerUserInfo],
tenantId: state instanceof TenantProjectState ? state.tenantId : undefined,
};
Expand Down

0 comments on commit e984a6c

Please sign in to comment.