Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createdAt time for signInWithIdp new users #5260

Merged
merged 1 commit into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Fix bug where disabling background triggers did nothing. (#5221)
- Fix bug in auth emulator where empty string should throw invalid email instead of missing email. (#3898)
- Fix bug in auth emulator in which createdAt was not set for signInWithIdp new users. (#5203)
4 changes: 3 additions & 1 deletion src/emulator/auth/operations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1608,9 +1608,11 @@ async function signInWithIdp(
oauthExpiresIn: coercePrimitiveToString(response.oauthExpireIn),
};
if (response.isNewUser) {
const timestamp = new Date();
let updates: Partial<UserInfo> = {
...accountUpdates.fields,
lastLoginAt: Date.now().toString(),
createdAt: timestamp.getTime().toString(),
lastLoginAt: timestamp.getTime().toString(),
providerUserInfo: [providerUserInfo],
tenantId: state instanceof TenantProjectState ? state.tenantId : undefined,
};
Expand Down