modular autoinit #6526
Merged
modular autoinit #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87c03a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jamesdaniels
changed the title
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (1,423,165 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
This was referenced Aug 12, 2022
|
FYI @hsubox76 Need to clean up but here's a first pass on an implementation. Any initial thoughts? We've started bashing on it go/web-frameworks-bug-bash-init-exp |
jamesdaniels
added a commit
to FirebaseExtended/firebase-framework-tools
that referenced
this pull request
Aug 16, 2022
* Addressed Angular not working, `defaultProject` is gone in new projects now * Added more error logging to the Angular codepath * `npm run dev` wasn't patching the globally installed CLI * Bumped version * Migrating to ESM * Adding nuxt & nuxt3 to Github Actions * Bumping deps * Fix dynamic import paths in Windows with pathToFileURL * Adding Windows tests to Actions * Marked as compatible with Node 16, 18. * Dropped Node 14 from Actions * Pack filesystem NPM overrides * Console log NPM install * Integrate with [firebase-js-sdk#6526](firebase/firebase-js-sdk#6526) and [firebase-tools##4868](firebase/firebase-tools#4868) * Next broke, `next export` no longer fails for fallbacks and api routes, detect these to determine if a Cloud Function should be spun up * Fixed relative directory handling * Silenced next export failures by spawning * Rearranged framework detection order so custom servers are first * Error if it could not determine the framework * Next minimal mode
jamesdaniels
changed the title
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
requested review from
avolkovi,
lisajian,
sam-gc,
yuchenshi,
maneesht,
tonyjhuang,
jsdt,
jmwski,
dwyfrequency and
hsubox76
as code owners
jamesdaniels
commented
Sep 17, 2022
| import { Auth, User } from '../model/public_types'; | ||
| import { getDefaultEmulatorHost, getExperimentalSetting } from '@firebase/util'; | ||
|
|
||
| const ID_TOKEN_MAX_AGE = 5 * 60; |
There was a problem hiding this comment.
should put this into the configuration object
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
jamesdaniels
commented
Sep 17, 2022
hsubox76
force-pushed
the
jamesdaniels_ssr_autoconfig
branch
from
e09043c
to
233cc69
Compare
maneesht
reviewed
Sep 27, 2022
yuchenshi
approved these changes
Sep 27, 2022
common/api-review/util.api.md
Outdated
| @@ -195,6 +195,23 @@ export class FirebaseError extends Error { | |||
| // @public | |||
| export type FirebaseSignInProvider = 'custom' | 'email' | 'password' | 'phone' | 'anonymous' | 'google.com' | 'facebook.com' | 'github.com' | 'twitter.com' | 'microsoft.com' | 'apple.com'; | |||
|
|
|||
| // Warning: (ae-missing-release-tag) "getDefaultAppConfig" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) | |||
There was a problem hiding this comment.
Please address these warnings
There was a problem hiding this comment.
Added @public flag and added more comments to everything in defaults.ts.
| if (authTokenSyncUrl) { | ||
| const mintCookie = mintCookieFactory(authTokenSyncUrl); | ||
| beforeAuthStateChanged(auth, mintCookie, () => { | ||
| void mintCookie(auth.currentUser); |
There was a problem hiding this comment.
Why is the Promise ignored? Please add a comment.
There was a problem hiding this comment.
Looks like I fixed an eslint error the wrong way. beforeAuthStateChanged does seem to await its callbacks so returned the promise instead.
| @@ -132,6 +140,12 @@ export function initializeApp( | |||
| }); | |||
| } | |||
|
|
|||
| options ||= getDefaultAppConfig(); | |||
There was a problem hiding this comment.
First time seeing this syntax. Thank you for the education
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_OR_assignment
There was a problem hiding this comment.
👍 Just mind that it overrides all falsy values—false, 0, "", null, undefined, NaN, etc. This can be surprise folk, especially with ints.
You can use the nullish form, ??= if you only want to override null & undefined.
yuchenshi
approved these changes
Sep 28, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC of go/firebase-api-client-autoinit