Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove json path and fix process check #6665

Merged
merged 2 commits into from Oct 7, 2022
Merged

Remove json path and fix process check #6665

merged 2 commits into from Oct 7, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 7, 2022

Fix bugs introduced in #6526:

  1. Remove __FIREBASE_DEFAULTS_PATH__ option to point to a JSON file path for modular autoinit defaults. This causes webpack warnings about dynamic require()s although the code is only meant to take that path in a Node environment. (See Warning: Critical dependency: the request of a dependency is an expression #6660). If we can figure out a way around this, we can add the functionality back.

  2. Fix the process check to be more robust and handle environments that have process but do not have process.env. This incorporates the fix in PR Fix modular autoinit breakage #6663

Fixes #6660
Fixes #6662

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

🦋 Changeset detected

Latest commit: 9b9875c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/util Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/database Patch
firebase Patch
@firebase/firestore-compat Patch
@firebase/firestore Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 7, 2022

Size Report 1

Affected Products

  • @firebase/util

    TypeBase (0a112bd)Merge (cdda435)Diff
    browser22.5 kB22.0 kB-426 B (-1.9%)
    esm523.9 kB23.4 kB-422 B (-1.8%)
    main29.5 kB28.8 kB-681 B (-2.3%)
    module22.5 kB22.0 kB-426 B (-1.9%)
  • bundle

    43 size changes

    TypeBase (0a112bd)Merge (cdda435)Diff
    analytics (logEvent)43.2 kB42.9 kB-345 B (-0.8%)
    app-check (CustomProvider)36.7 kB36.3 kB-345 B (-0.9%)
    app-check (ReCaptchaEnterpriseProvider)39.1 kB38.7 kB-345 B (-0.9%)
    app-check (ReCaptchaV3Provider)39.0 kB38.7 kB-345 B (-0.9%)
    auth (Anonymous)67.7 kB67.3 kB-345 B (-0.5%)
    auth (EmailAndPassword)71.8 kB71.4 kB-345 B (-0.5%)
    auth (GoogleFBTwitterGitHubPopup)94.1 kB93.8 kB-345 B (-0.4%)
    auth (GooglePopup)91.4 kB91.1 kB-345 B (-0.4%)
    auth (GoogleRedirect)91.6 kB91.3 kB-345 B (-0.4%)
    auth (Phone)77.8 kB77.5 kB-345 B (-0.4%)
    database (Append to a list of data)148 kB147 kB-345 B (-0.2%)
    database (Filtering data)147 kB146 kB-345 B (-0.2%)
    database (Listen for child events)163 kB162 kB-345 B (-0.2%)
    database (Listen for value events + Detach listeners)163 kB162 kB-345 B (-0.2%)
    database (Listen for value events)163 kB162 kB-345 B (-0.2%)
    database (Read data once)162 kB162 kB-345 B (-0.2%)
    database (Save data as transactions)165 kB164 kB-345 B (-0.2%)
    database (Sort data)148 kB148 kB-345 B (-0.2%)
    database (Write data)147 kB147 kB-345 B (-0.2%)
    firestore (Persistence)276 kB276 kB-345 B (-0.1%)
    firestore (Query Cursors)213 kB213 kB-345 B (-0.2%)
    firestore (Query)214 kB214 kB-345 B (-0.2%)
    firestore (Read data once)202 kB202 kB-345 B (-0.2%)
    firestore (Realtime updates)205 kB204 kB-345 B (-0.2%)
    firestore (Transaction)186 kB186 kB-345 B (-0.2%)
    firestore (Write data)186 kB185 kB-345 B (-0.2%)
    firestore-lite (Query Cursors)71.3 kB71.0 kB-345 B (-0.5%)
    firestore-lite (Query)74.5 kB74.2 kB-345 B (-0.5%)
    firestore-lite (Read data once)58.9 kB58.6 kB-345 B (-0.6%)
    firestore-lite (Transaction)83.5 kB83.2 kB-345 B (-0.4%)
    firestore-lite (Write data)68.7 kB68.3 kB-345 B (-0.5%)
    functions (call)30.9 kB30.5 kB-345 B (-1.1%)
    messaging (send + receive)46.6 kB46.2 kB-345 B (-0.7%)
    performance (trace)51.0 kB50.7 kB-345 B (-0.7%)
    remote-config (getAndFetch)45.6 kB45.3 kB-345 B (-0.8%)
    storage (getBytes)40.0 kB39.7 kB-345 B (-0.9%)
    storage (getDownloadURL)42.1 kB41.8 kB-345 B (-0.8%)
    storage (getMetadata)41.5 kB41.2 kB-345 B (-0.8%)
    storage (list + listAll)41.0 kB40.6 kB-345 B (-0.8%)
    storage (updateMetadata)41.8 kB41.5 kB-345 B (-0.8%)
    storage (uploadBytes)46.4 kB46.0 kB-345 B (-0.7%)
    storage (uploadBytesResumable)56.2 kB55.9 kB-345 B (-0.6%)
    storage (uploadString)46.6 kB46.2 kB-345 B (-0.7%)

  • firebase

    13 size changes

    TypeBase (0a112bd)Merge (cdda435)Diff
    firebase-app-compat.js29.0 kB28.6 kB-326 B (-1.1%)
    firebase-app.js91.7 kB91.0 kB-710 B (-0.8%)
    firebase-auth-compat.js126 kB126 kB-326 B (-0.3%)
    firebase-auth-react-native.js149 kB149 kB-323 B (-0.2%)
    firebase-auth.js118 kB117 kB-323 B (-0.3%)
    firebase-compat.js740 kB740 kB-326 B (-0.0%)
    firebase-database.js154 kB154 kB-323 B (-0.2%)
    firebase-firestore-lite.js88.9 kB88.6 kB-323 B (-0.4%)
    firebase-firestore.js314 kB314 kB-323 B (-0.1%)
    firebase-functions.js10.9 kB10.5 kB-323 B (-3.0%)
    firebase-performance-standalone-compat.es2017.js90.2 kB89.8 kB-323 B (-0.4%)
    firebase-performance-standalone-compat.js66.7 kB66.3 kB-321 B (-0.5%)
    firebase-storage.js38.4 kB38.1 kB-323 B (-0.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OUyoIXAvBw.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/analytics

    • getAnalytics

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps43.1 kB42.8 kB-345 B (-0.8%)
  • @firebase/app

    • getApp

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps24.3 kB24.0 kB-345 B (-1.4%)
    • initializeApp

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps24.2 kB23.9 kB-345 B (-1.4%)
  • @firebase/app-check

    • initializeAppCheck

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps35.7 kB35.3 kB-345 B (-1.0%)
  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.5 kB52.2 kB-345 B (-0.7%)
    • ActionCodeURL

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.6 kB53.3 kB-345 B (-0.6%)
    • AuthCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.5 kB52.2 kB-345 B (-0.7%)
    • AuthErrorCodes

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps56.9 kB56.6 kB-345 B (-0.6%)
    • EmailAuthCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps54.5 kB54.1 kB-345 B (-0.6%)
    • EmailAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps56.1 kB55.8 kB-345 B (-0.6%)
    • FacebookAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.5 kB57.1 kB-345 B (-0.6%)
    • FactorId

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • GithubAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.5 kB57.1 kB-345 B (-0.6%)
    • GoogleAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.5 kB57.1 kB-345 B (-0.6%)
    • OAuthCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps54.6 kB54.2 kB-345 B (-0.6%)
    • OAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps58.4 kB58.1 kB-345 B (-0.6%)
    • OperationType

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.4 kB52.0 kB-345 B (-0.7%)
    • PhoneAuthCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps54.6 kB54.2 kB-345 B (-0.6%)
    • PhoneAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps56.3 kB55.9 kB-345 B (-0.6%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.3 kB52.9 kB-345 B (-0.6%)
    • ProviderId

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.4 kB52.1 kB-345 B (-0.7%)
    • RecaptchaVerifier

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps58.8 kB58.5 kB-345 B (-0.6%)
    • SAMLAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps58.7 kB58.4 kB-345 B (-0.6%)
    • SignInMethod

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.4 kB52.1 kB-345 B (-0.7%)
    • TwitterAuthProvider

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.5 kB57.1 kB-345 B (-0.6%)
    • applyActionCode

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.5 kB52.2 kB-345 B (-0.7%)
    • beforeAuthStateChanged

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.4 kB52.0 kB-345 B (-0.7%)
    • browserLocalPersistence

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps55.8 kB55.4 kB-345 B (-0.6%)
    • browserPopupRedirectResolver

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps76.9 kB76.6 kB-345 B (-0.4%)
    • browserSessionPersistence

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps55.8 kB55.5 kB-345 B (-0.6%)
    • checkActionCode

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.5 kB53.1 kB-345 B (-0.6%)
    • confirmPasswordReset

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.6 kB52.2 kB-345 B (-0.7%)
    • connectAuthEmulator

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps54.0 kB53.7 kB-345 B (-0.6%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.4 kB53.1 kB-345 B (-0.6%)
    • debugErrorMap

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps63.4 kB63.1 kB-345 B (-0.5%)
    • deleteUser

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.8 kB52.4 kB-345 B (-0.7%)
    • getAdditionalUserInfo

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.6 kB53.3 kB-345 B (-0.6%)
    • getAuth

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps93.5 kB93.1 kB-345 B (-0.4%)
    • getIdToken

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • getIdTokenResult

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB51.9 kB-345 B (-0.7%)
    • getMultiFactorResolver

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps55.0 kB54.7 kB-345 B (-0.6%)
    • getRedirectResult

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps60.0 kB59.6 kB-345 B (-0.6%)
    • inMemoryPersistence

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB51.9 kB-345 B (-0.7%)
    • indexedDBLocalPersistence

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps59.7 kB59.4 kB-345 B (-0.6%)
    • initializeAuth

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.0 kB52.7 kB-345 B (-0.7%)
    • isSignInWithEmailLink

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.7 kB53.4 kB-345 B (-0.6%)
    • linkWithCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.3 kB53.0 kB-345 B (-0.6%)
    • linkWithPhoneNumber

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.0 kB56.7 kB-345 B (-0.6%)
    • linkWithPopup

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps63.6 kB63.2 kB-345 B (-0.5%)
    • linkWithRedirect

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps58.7 kB58.4 kB-345 B (-0.6%)
    • multiFactor

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps54.6 kB54.2 kB-345 B (-0.6%)
    • onAuthStateChanged

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • onIdTokenChanged

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • parseActionCodeURL

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.7 kB53.3 kB-345 B (-0.6%)
    • prodErrorMap

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB51.9 kB-345 B (-0.7%)
    • reauthenticateWithCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.9 kB53.6 kB-345 B (-0.6%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.6 kB57.2 kB-345 B (-0.6%)
    • reauthenticateWithPopup

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps63.6 kB63.2 kB-345 B (-0.5%)
    • reauthenticateWithRedirect

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps58.5 kB58.1 kB-345 B (-0.6%)
    • reload

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB51.9 kB-345 B (-0.7%)
    • sendEmailVerification

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.3 kB53.0 kB-345 B (-0.6%)
    • sendPasswordResetEmail

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.3 kB52.9 kB-345 B (-0.6%)
    • sendSignInLinkToEmail

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.3 kB53.0 kB-345 B (-0.6%)
    • setPersistence

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • signInAnonymously

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.6 kB53.2 kB-345 B (-0.6%)
    • signInWithCredential

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.7 kB53.3 kB-345 B (-0.6%)
    • signInWithCustomToken

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.4 kB53.1 kB-345 B (-0.6%)
    • signInWithEmailAndPassword

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.6 kB57.2 kB-345 B (-0.6%)
    • signInWithEmailLink

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.8 kB57.5 kB-345 B (-0.6%)
    • signInWithPhoneNumber

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps57.3 kB57.0 kB-345 B (-0.6%)
    • signInWithPopup

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps63.5 kB63.2 kB-345 B (-0.5%)
    • signInWithRedirect

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps58.2 kB57.8 kB-345 B (-0.6%)
    • signOut

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • unlink

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.9 kB52.5 kB-345 B (-0.7%)
    • updateCurrentUser

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • updateEmail

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.6 kB52.3 kB-345 B (-0.7%)
    • updatePassword

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.6 kB52.3 kB-345 B (-0.7%)
    • updatePhoneNumber

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.1 kB52.7 kB-345 B (-0.7%)
    • updateProfile

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.8 kB52.5 kB-345 B (-0.7%)
    • useDeviceLanguage

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps52.3 kB52.0 kB-345 B (-0.7%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.4 kB53.0 kB-345 B (-0.6%)
    • verifyPasswordResetCode

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps53.6 kB53.2 kB-345 B (-0.6%)
  • @firebase/database

    • getDatabase

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps145 kB145 kB-345 B (-0.2%)
  • @firebase/firestore

    • getFirestore

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps85.4 kB85.0 kB-345 B (-0.4%)
  • @firebase/functions

    • getFunctions

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps27.1 kB26.7 kB-345 B (-1.3%)
  • @firebase/installations

    • getInstallations

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps33.1 kB32.7 kB-345 B (-1.0%)
  • @firebase/messaging

    • getMessaging

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps46.2 kB45.9 kB-345 B (-0.7%)
  • @firebase/performance

    • getPerformance

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps50.9 kB50.6 kB-345 B (-0.7%)
  • @firebase/remote-config

    • getRemoteConfig

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps43.6 kB43.3 kB-345 B (-0.8%)
  • @firebase/storage

    • getStorage

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size-with-ext-deps35.6 kB35.3 kB-345 B (-1.0%)
  • @firebase/util

    • getDefaultAppConfig

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size4.14 kB3.80 kB-345 B (-8.3%)
      size-with-ext-deps4.14 kB3.80 kB-345 B (-8.3%)
    • getDefaultEmulatorHost

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size4.19 kB3.84 kB-345 B (-8.2%)
      size-with-ext-deps4.19 kB3.84 kB-345 B (-8.2%)
    • getExperimentalSetting

      Size

      TypeBase (0a112bd)Merge (835b577)Diff
      size4.15 kB3.80 kB-345 B (-8.3%)
      size-with-ext-deps4.15 kB3.80 kB-345 B (-8.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HMi3NyvTJP.html

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 29d0340 into master Oct 7, 2022
@hsubox76 hsubox76 deleted the ch-rm-json-path branch October 7, 2022 22:07
@google-oss-bot google-oss-bot mentioned this pull request Oct 10, 2022
@firebase firebase locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants