Skip to content

Commit

Permalink
Address feedback from the bug bash (#24)
Browse files Browse the repository at this point in the history
* Addressed Angular not working, `defaultProject` is gone in new projects now
* Added more error logging to the Angular codepath
* `npm run dev` wasn't patching the globally installed CLI
* Bumped version
* Migrating to ESM
* Adding nuxt & nuxt3 to Github Actions
* Bumping deps
* Fix dynamic import paths in Windows with pathToFileURL
* Adding Windows tests to Actions
* Marked as compatible with Node 16, 18.
* Dropped Node 14 from Actions
* Pack filesystem NPM overrides
* Console log NPM install
* Integrate with [firebase-js-sdk#6526](firebase/firebase-js-sdk#6526) and [firebase-tools##4868](firebase/firebase-tools#4868)
* Next broke, `next export` no longer fails for fallbacks and api routes, detect these to determine if a Cloud Function should be spun up
* Fixed relative directory handling
* Silenced next export failures by spawning
* Rearranged framework detection order so custom servers are first
* Error if it could not determine the framework
* Next minimal mode
  • Loading branch information
jamesdaniels committed Aug 16, 2022
1 parent 918b28a commit 06a731d
Show file tree
Hide file tree
Showing 26 changed files with 4,538 additions and 6,751 deletions.
31 changes: 17 additions & 14 deletions .github/workflows/test.yml
Expand Up @@ -51,14 +51,21 @@ jobs:
needs: build
strategy:
matrix:
os: [ ubuntu-latest, macos-latest ]
node: [ "14", "16" ]
framework: [ "next", "angular", "custom" ]
os: [ ubuntu-latest, macos-latest, windows-latest ]
node: [ "16", "18" ]
framework: [ "next", "angular", "custom", "nuxt", "nuxt3" ]
exclude:
# seeing failures on this one, skip for now
- os: ubuntu-latest
node: 14
framework: angular
# Engine failures for Node 18
- node: 18
framework: next
- node: 18
framework: nuxt
- node: 18
framework: nuxt3
# JSON serialization problem
- node: 16
framework: nuxt
os: windows-latest
fail-fast: false
name: Test ${{ matrix.framework }} on Node ${{ matrix.node }} (${{ matrix.os }})
steps:
Expand Down Expand Up @@ -91,7 +98,7 @@ jobs:
- name: Test
run: |
npm i -g firebase-tools
npm i --only production --force --ignore-scripts --save --prefix $(npm root -g)/firebase-tools $(npm pack .)
node --loader ts-node/esm ./tools/dev.ts
firebase --open-sesame frameworkawareness
npm run test:${{ matrix.framework }}
env:
Expand All @@ -103,7 +110,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, macos-latest ]
node: [ "14", "16" ]
node: [ "16" ] # lots of engine failures with Node 18, skip for now
exclude:
# we build with this combination, safely skip
- os: ubuntu-latest
Expand All @@ -130,11 +137,7 @@ jobs:
- name: Build
run: npm run build
- name: Test
run: |
npm i -g firebase-tools
npm i --only production --force --ignore-scripts --save --prefix $(npm root -g)/firebase-tools $(npm pack .)
firebase --open-sesame frameworkawareness
npm run test
run: npm run test
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

Expand Down

0 comments on commit 06a731d

Please sign in to comment.