Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug fixes #1573

Merged
merged 11 commits into from Oct 26, 2022
Merged

minor bug fixes #1573

merged 11 commits into from Oct 26, 2022

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Oct 20, 2022

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022

🦋 Changeset detected

Latest commit: 96ef53f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/babel-preset-legend-studio Patch
@finos/eslint-plugin-legend-studio Patch
@finos/legend-application Patch
@finos/legend-application-query Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-taxonomy Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy-deployment Patch
@finos/legend-art Patch
@finos/legend-dev-utils Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-persistence-cloud Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-format-json-schema Patch
@finos/legend-extension-format-morphir Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-graph Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-shared Patch
@finos/legend-storage Patch
@finos/stylelint-config-legend-studio Patch
@finos/legend-manual-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Oct 20, 2022
@akphi akphi marked this pull request as draft October 20, 2022 15:41
@akphi akphi force-pushed the taro branch 2 times, most recently from 6da742a to 18f3c1d Compare October 22, 2022 01:44
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #1573 (96ef53f) into master (d41811e) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1573      +/-   ##
==========================================
- Coverage   42.14%   42.12%   -0.02%     
==========================================
  Files        1315     1315              
  Lines       57684    57720      +36     
  Branches    13020    13049      +29     
==========================================
+ Hits        24309    24314       +5     
- Misses      33283    33312      +29     
- Partials       92       94       +2     
Impacted Files Coverage Δ
...y/src/components/QueryEditorComponentTestUtils.tsx 5.55% <0.00%> (ø)
...-application-query/src/stores/LegendQueryRouter.ts 4.44% <0.00%> (-1.62%) ⬇️
...-panel/mapping-editor/EnumerationMappingEditor.tsx 73.98% <ø> (ø)
...src/components/editor/side-bar/ProjectOverview.tsx 9.04% <0.00%> (ø)
...cation-studio/src/stores/editor/NewElementState.ts 41.36% <ø> (ø)
...ion-studio/src/stores/editor/StandardEditorMode.ts 60.00% <0.00%> (ø)
...c/components/ApplicationStoreProviderTestUtils.tsx 0.00% <0.00%> (ø)
...nents/WebApplicationNavigatorProviderTestUtils.tsx 12.50% <0.00%> (ø)
.../legend-application/src/stores/ApplicationStore.ts 16.83% <ø> (+0.16%) ⬆️
...gend-application/src/stores/PureLanguageSupport.ts 14.28% <ø> (ø)
... and 16 more

@akphi akphi changed the title temp minor bug fixes Oct 26, 2022
@akphi akphi marked this pull request as ready for review October 26, 2022 13:37
@MauricioUyaguari MauricioUyaguari merged commit 6689b21 into finos:master Oct 26, 2022
@akphi akphi deleted the taro branch October 26, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
2 participants