Skip to content

Commit

Permalink
minor bug fixes (#1573)
Browse files Browse the repository at this point in the history
* minor fixes

* bump dependencies

* update post dependency bumping

* use syntactic sugar for jest mockResolvedValue

* fixes #1589

* minor cleanups

* fix problems with shortkey service clashing with monaco-editor and browser hotkeys

* studio: make explorer Copy Link point to element in workspace

* improve ESM docs

* fixes #1590

* fixes #1588
  • Loading branch information
akphi committed Oct 26, 2022
1 parent d41811e commit 6689b21
Show file tree
Hide file tree
Showing 86 changed files with 1,234 additions and 838 deletions.
5 changes: 5 additions & 0 deletions .changeset/eight-pans-try.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@finos/legend-application-studio': patch
---

Service editor: the default lambda created is now the basic lambda `|''` instead of the stubbed empty lambda ([#1588](https://github.com/finos/legend-studio/issues/1588)).
5 changes: 5 additions & 0 deletions .changeset/giant-rats-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@finos/legend-query-builder': patch
---

Fix a bug where milestoning editor modal cannot be closed ([#1589](https://github.com/finos/legend-studio/issues/1589)).
36 changes: 36 additions & 0 deletions .changeset/old-paws-relax.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@finos/babel-preset-legend-studio': patch
'@finos/eslint-plugin-legend-studio': patch
'@finos/legend-application': patch
'@finos/legend-application-query': patch
'@finos/legend-application-query-bootstrap': patch
'@finos/legend-application-query-deployment': patch
'@finos/legend-application-studio': patch
'@finos/legend-application-studio-bootstrap': patch
'@finos/legend-application-studio-deployment': patch
'@finos/legend-application-taxonomy': patch
'@finos/legend-application-taxonomy-bootstrap': patch
'@finos/legend-application-taxonomy-deployment': patch
'@finos/legend-art': patch
'@finos/legend-dev-utils': patch
'@finos/legend-extension-dsl-data-space': patch
'@finos/legend-extension-dsl-diagram': patch
'@finos/legend-extension-dsl-mastery': patch
'@finos/legend-extension-dsl-persistence': patch
'@finos/legend-extension-dsl-persistence-cloud': patch
'@finos/legend-extension-dsl-service': patch
'@finos/legend-extension-dsl-text': patch
'@finos/legend-extension-format-json-schema': patch
'@finos/legend-extension-format-morphir': patch
'@finos/legend-extension-store-flat-data': patch
'@finos/legend-extension-store-relational': patch
'@finos/legend-extension-store-service-store': patch
'@finos/legend-extension-tracer-zipkin': patch
'@finos/legend-graph': patch
'@finos/legend-query-builder': patch
'@finos/legend-server-depot': patch
'@finos/legend-server-sdlc': patch
'@finos/legend-shared': patch
'@finos/legend-storage': patch
'@finos/stylelint-config-legend-studio': patch
---
36 changes: 36 additions & 0 deletions .changeset/perfect-cherries-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@finos/babel-preset-legend-studio': patch
'@finos/eslint-plugin-legend-studio': patch
'@finos/legend-application': patch
'@finos/legend-application-query': patch
'@finos/legend-application-query-bootstrap': patch
'@finos/legend-application-query-deployment': patch
'@finos/legend-application-studio': patch
'@finos/legend-application-studio-bootstrap': patch
'@finos/legend-application-studio-deployment': patch
'@finos/legend-application-taxonomy': patch
'@finos/legend-application-taxonomy-bootstrap': patch
'@finos/legend-application-taxonomy-deployment': patch
'@finos/legend-art': patch
'@finos/legend-dev-utils': patch
'@finos/legend-extension-dsl-data-space': patch
'@finos/legend-extension-dsl-diagram': patch
'@finos/legend-extension-dsl-mastery': patch
'@finos/legend-extension-dsl-persistence': patch
'@finos/legend-extension-dsl-persistence-cloud': patch
'@finos/legend-extension-dsl-service': patch
'@finos/legend-extension-dsl-text': patch
'@finos/legend-extension-format-json-schema': patch
'@finos/legend-extension-format-morphir': patch
'@finos/legend-extension-store-flat-data': patch
'@finos/legend-extension-store-relational': patch
'@finos/legend-extension-store-service-store': patch
'@finos/legend-extension-tracer-zipkin': patch
'@finos/legend-graph': patch
'@finos/legend-query-builder': patch
'@finos/legend-server-depot': patch
'@finos/legend-server-sdlc': patch
'@finos/legend-shared': patch
'@finos/legend-storage': patch
'@finos/stylelint-config-legend-studio': patch
---
36 changes: 36 additions & 0 deletions .changeset/purple-fishes-drop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@finos/babel-preset-legend-studio': patch
'@finos/eslint-plugin-legend-studio': patch
'@finos/legend-application': patch
'@finos/legend-application-query': patch
'@finos/legend-application-query-bootstrap': patch
'@finos/legend-application-query-deployment': patch
'@finos/legend-application-studio': patch
'@finos/legend-application-studio-bootstrap': patch
'@finos/legend-application-studio-deployment': patch
'@finos/legend-application-taxonomy': patch
'@finos/legend-application-taxonomy-bootstrap': patch
'@finos/legend-application-taxonomy-deployment': patch
'@finos/legend-art': patch
'@finos/legend-dev-utils': patch
'@finos/legend-extension-dsl-data-space': patch
'@finos/legend-extension-dsl-diagram': patch
'@finos/legend-extension-dsl-mastery': patch
'@finos/legend-extension-dsl-persistence': patch
'@finos/legend-extension-dsl-persistence-cloud': patch
'@finos/legend-extension-dsl-service': patch
'@finos/legend-extension-dsl-text': patch
'@finos/legend-extension-format-json-schema': patch
'@finos/legend-extension-format-morphir': patch
'@finos/legend-extension-store-flat-data': patch
'@finos/legend-extension-store-relational': patch
'@finos/legend-extension-store-service-store': patch
'@finos/legend-extension-tracer-zipkin': patch
'@finos/legend-graph': patch
'@finos/legend-query-builder': patch
'@finos/legend-server-depot': patch
'@finos/legend-server-sdlc': patch
'@finos/legend-shared': patch
'@finos/legend-storage': patch
'@finos/stylelint-config-legend-studio': patch
---
5 changes: 5 additions & 0 deletions .changeset/serious-llamas-count.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@finos/legend-query-builder': patch
---

Fix a problem where query builder setup panels do not allow selection when there is only one option and no selected option ([#1590](https://github.com/finos/legend-studio/issues/1590)).
36 changes: 36 additions & 0 deletions .changeset/six-ties-camp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@finos/babel-preset-legend-studio': patch
'@finos/eslint-plugin-legend-studio': patch
'@finos/legend-application': patch
'@finos/legend-application-query': patch
'@finos/legend-application-query-bootstrap': patch
'@finos/legend-application-query-deployment': patch
'@finos/legend-application-studio': patch
'@finos/legend-application-studio-bootstrap': patch
'@finos/legend-application-studio-deployment': patch
'@finos/legend-application-taxonomy': patch
'@finos/legend-application-taxonomy-bootstrap': patch
'@finos/legend-application-taxonomy-deployment': patch
'@finos/legend-art': patch
'@finos/legend-dev-utils': patch
'@finos/legend-extension-dsl-data-space': patch
'@finos/legend-extension-dsl-diagram': patch
'@finos/legend-extension-dsl-mastery': patch
'@finos/legend-extension-dsl-persistence': patch
'@finos/legend-extension-dsl-persistence-cloud': patch
'@finos/legend-extension-dsl-service': patch
'@finos/legend-extension-dsl-text': patch
'@finos/legend-extension-format-json-schema': patch
'@finos/legend-extension-format-morphir': patch
'@finos/legend-extension-store-flat-data': patch
'@finos/legend-extension-store-relational': patch
'@finos/legend-extension-store-service-store': patch
'@finos/legend-extension-tracer-zipkin': patch
'@finos/legend-graph': patch
'@finos/legend-query-builder': patch
'@finos/legend-server-depot': patch
'@finos/legend-server-sdlc': patch
'@finos/legend-shared': patch
'@finos/legend-storage': patch
'@finos/stylelint-config-legend-studio': patch
---
36 changes: 36 additions & 0 deletions .changeset/weak-bats-push.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@finos/babel-preset-legend-studio': patch
'@finos/eslint-plugin-legend-studio': patch
'@finos/legend-application': patch
'@finos/legend-application-query': patch
'@finos/legend-application-query-bootstrap': patch
'@finos/legend-application-query-deployment': patch
'@finos/legend-application-studio': patch
'@finos/legend-application-studio-bootstrap': patch
'@finos/legend-application-studio-deployment': patch
'@finos/legend-application-taxonomy': patch
'@finos/legend-application-taxonomy-bootstrap': patch
'@finos/legend-application-taxonomy-deployment': patch
'@finos/legend-art': patch
'@finos/legend-dev-utils': patch
'@finos/legend-extension-dsl-data-space': patch
'@finos/legend-extension-dsl-diagram': patch
'@finos/legend-extension-dsl-mastery': patch
'@finos/legend-extension-dsl-persistence': patch
'@finos/legend-extension-dsl-persistence-cloud': patch
'@finos/legend-extension-dsl-service': patch
'@finos/legend-extension-dsl-text': patch
'@finos/legend-extension-format-json-schema': patch
'@finos/legend-extension-format-morphir': patch
'@finos/legend-extension-store-flat-data': patch
'@finos/legend-extension-store-relational': patch
'@finos/legend-extension-store-service-store': patch
'@finos/legend-extension-tracer-zipkin': patch
'@finos/legend-graph': patch
'@finos/legend-query-builder': patch
'@finos/legend-server-depot': patch
'@finos/legend-server-sdlc': patch
'@finos/legend-shared': patch
'@finos/legend-storage': patch
'@finos/stylelint-config-legend-studio': patch
---
4 changes: 2 additions & 2 deletions fixtures/legend-mock-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"start": "node lib/index.js"
},
"dependencies": {
"@fastify/cors": "8.1.0",
"@fastify/cors": "8.1.1",
"fastify": "4.9.2"
},
"devDependencies": {
"@finos/legend-dev-utils": "workspace:*",
"cross-env": "7.0.3",
"eslint": "8.25.0",
"eslint": "8.26.0",
"nodemon": "2.0.20",
"npm-run-all": "4.1.5",
"rimraf": "3.0.2",
Expand Down
16 changes: 2 additions & 14 deletions fixtures/legend-mock-server/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,7 @@
*/

import { fastify } from 'fastify';
/**
* Previously, these exports rely on ES module interop to expose `default` export
* properly. But since we use `ESM` for Typescript resolution now, we lose this
*
* TODO: remove these when the package properly work with Typescript's nodenext
* module resolution
*
* @workaround ESM
* See https://github.com/microsoft/TypeScript/issues/49298
* See https://github.com/microsoft/TypeScript/issues/50690
* See https://github.com/fastify/fastify-cors/pull/231
*/
import { default as FastifyCORS } from '@fastify/cors';
import { fastifyCors } from '@fastify/cors';
import TAXONOMY_TREE_DATA from './TEST_DATA__TaxonomyTreeData.json' assert { type: 'json' };
import DOCUMENTATION_DATA from './DummyDocumentationData.json' assert { type: 'json' };

Expand All @@ -40,7 +28,7 @@ const server = fastify({
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
server.register(FastifyCORS.default, {
server.register(fastifyCors, {
methods: ['OPTIONS'],
origin: [/localhost/],
credentials: true,
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,21 @@
"devDependencies": {
"@actions/core": "1.10.0",
"@actions/github": "5.1.1",
"@babel/core": "7.19.3",
"@babel/core": "7.19.6",
"@changesets/cli": "2.25.0",
"@finos/babel-preset-legend-studio": "workspace:*",
"@finos/eslint-plugin-legend-studio": "workspace:*",
"@finos/legend-dev-utils": "workspace:*",
"@finos/stylelint-config-legend-studio": "workspace:*",
"@types/node": "18.11.2",
"@types/node": "18.11.5",
"chalk": "5.1.2",
"cross-env": "7.0.3",
"envinfo": "7.8.1",
"eslint": "8.25.0",
"eslint": "8.26.0",
"fs-extra": "10.1.0",
"husky": "8.0.1",
"inquirer": "9.1.4",
"jest": "29.2.1",
"jest": "29.2.2",
"lint-staged": "13.0.3",
"micromatch": "4.0.5",
"npm-run-all": "4.1.5",
Expand All @@ -112,7 +112,7 @@
"semver": "7.3.8",
"sort-package-json": "2.0.0",
"stylelint": "14.14.0",
"typedoc": "0.23.17",
"typedoc": "0.23.18",
"typescript": "4.8.4",
"yargs": "17.6.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-preset/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
},
"devDependencies": {
"cross-env": "7.0.3",
"eslint": "8.25.0",
"eslint": "8.26.0",
"rimraf": "3.0.2",
"typescript": "4.8.4"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@
"publish:snapshot": "node ../../scripts/release/publishDevSnapshot.js"
},
"dependencies": {
"@babel/core": "7.19.3",
"@babel/core": "7.19.6",
"@babel/eslint-parser": "7.19.1",
"@typescript-eslint/eslint-plugin": "5.40.1",
"@typescript-eslint/parser": "5.40.1",
"@typescript-eslint/eslint-plugin": "5.41.0",
"@typescript-eslint/parser": "5.41.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-import": "2.26.0",
"eslint-plugin-prettier": "4.2.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/legend-application-query-bootstrap/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@
"@finos/legend-extension-store-service-store": "workspace:*",
"@finos/legend-graph": "workspace:*",
"@finos/legend-shared": "workspace:*",
"@types/react": "18.0.21",
"@types/react": "18.0.23",
"react": "18.2.0"
},
"devDependencies": {
"@finos/legend-dev-utils": "workspace:*",
"cross-env": "7.0.3",
"eslint": "8.25.0",
"eslint": "8.26.0",
"npm-run-all": "4.1.5",
"rimraf": "3.0.2",
"sass": "1.55.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/legend-application-query-deployment/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@finos/legend-dev-utils": "workspace:*",
"copy-webpack-plugin": "11.0.0",
"cross-env": "7.0.3",
"eslint": "8.25.0",
"eslint": "8.26.0",
"npm-run-all": "4.1.5",
"rimraf": "3.0.2",
"typescript": "4.8.4",
Expand Down
10 changes: 5 additions & 5 deletions packages/legend-application-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
"@finos/legend-shared": "workspace:*",
"@finos/legend-storage": "workspace:*",
"@testing-library/react": "13.4.0",
"@types/react": "18.0.21",
"@types/react-dom": "18.0.6",
"@types/react": "18.0.23",
"@types/react-dom": "18.0.7",
"mobx": "6.6.2",
"mobx-react-lite": "3.4.0",
"react": "18.2.0",
Expand All @@ -61,10 +61,10 @@
},
"devDependencies": {
"@finos/legend-dev-utils": "workspace:*",
"@jest/globals": "29.2.1",
"@jest/globals": "29.2.2",
"cross-env": "7.0.3",
"eslint": "8.25.0",
"jest": "29.2.1",
"eslint": "8.26.0",
"jest": "29.2.2",
"npm-run-all": "4.1.5",
"rimraf": "3.0.2",
"sass": "1.55.0",
Expand Down

0 comments on commit 6689b21

Please sign in to comment.