minor fixes

finos · Oct 22, 2022 · 18f3c1d · 18f3c1d
1 parent 7fbbf97
commit 18f3c1d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/packages/legend-application-query/src/stores/LegendQueryRouter.ts b/packages/legend-application-query/src/stores/LegendQueryRouter.ts
@@ -69,10 +69,16 @@ export const generateQuerySetupRoute = (
   addQueryParamsStringToUrl(
     generatePath(LEGEND_QUERY_ROUTE_PATTERN.SETUP, {}),
     stringifyQueryParams({
-      [LEGEND_QUERY_SETUP_QUERY_PARAM_TOKEN.SHOW_ALL_GROUPS]: showAllGroups,
+      [LEGEND_QUERY_SETUP_QUERY_PARAM_TOKEN.SHOW_ALL_GROUPS]: showAllGroups
+        ? encodeURIComponent(showAllGroups)
+        : showAllGroups,
       [LEGEND_QUERY_SETUP_QUERY_PARAM_TOKEN.SHOW_ADVANCED_ACTIONS]:
-        showAdvancedActions,
-      [LEGEND_QUERY_SETUP_QUERY_PARAM_TOKEN.TAG]: tag,
+        showAdvancedActions
+          ? encodeURIComponent(showAdvancedActions)
+          : undefined,
+      [LEGEND_QUERY_SETUP_QUERY_PARAM_TOKEN.TAG]: tag
+        ? encodeURIComponent(tag)
+        : undefined,
     }),
   );
 
@@ -143,7 +149,9 @@ export const generateServiceQueryCreatorRoute = (
       [LEGEND_QUERY_PATH_PARAM_TOKEN.SERVICE_PATH]: servicePath,
     }),
     stringifyQueryParams({
-      [LEGEND_QUERY_QUERY_PARAM_TOKEN.SERVICE_EXECUTION_KEY]: executionKey,
+      [LEGEND_QUERY_QUERY_PARAM_TOKEN.SERVICE_EXECUTION_KEY]: executionKey
+        ? encodeURIComponent(executionKey)
+        : executionKey,
     }),
   );
 

diff --git a/packages/legend-application/src/stores/ApplicationStore.ts b/packages/legend-application/src/stores/ApplicationStore.ts
@@ -382,7 +382,6 @@ export class ApplicationStore<
     await navigator.clipboard.writeText(text).catch((error) => {
       this.notifyError(error);
     });
-    return;
   }
 
   notifyUnsupportedFeature(featureName: string): void {

diff --git a/packages/legend-extension-dsl-data-space/src/stores/query/DSL_DataSpace_LegendQueryRouter.ts b/packages/legend-extension-dsl-data-space/src/stores/query/DSL_DataSpace_LegendQueryRouter.ts
@@ -82,6 +82,8 @@ export const generateDataSpaceQueryCreatorRoute = (
       },
     ),
     stringifyQueryParams({
-      [DATA_SPACE_QUERY_CREATOR_QUERY_PARAM_TOKEN.CLASS_PATH]: classPath,
+      [DATA_SPACE_QUERY_CREATOR_QUERY_PARAM_TOKEN.CLASS_PATH]: classPath
+        ? encodeURIComponent(classPath)
+        : undefined,
     }),
   );