Add controlList to DOM property whitelist #9940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
approved these changes
Jun 13, 2017
docs/docs/reference-dom-elements.md
Outdated
| @@ -104,8 +104,8 @@ React supports all `data-*` and `aria-*` attributes as well as these attributes: | |||
| accept acceptCharset accessKey action allowFullScreen allowTransparency alt | |||
| async autoComplete autoFocus autoPlay capture cellPadding cellSpacing challenge | |||
| charSet checked cite classID className colSpan cols content contentEditable | |||
| contextMenu controls coords crossOrigin data dateTime default defer dir | |||
| disabled download draggable encType form formAction formEncType formMethod | |||
| contextMenu controls controlList coords crossOrigin data dateTime default defer | |||
There was a problem hiding this comment.
This should be "controlsList" right?
nhunzaker
force-pushed
the
gh-9594-control-list-attribute
branch
from
08e8f9b
to
331ef3e
Compare
|
Got it. I'll cherry pick to 15.6 |
nhunzaker
added a commit
that referenced
this pull request
Aug 10, 2017
nhunzaker
added a commit
that referenced
this pull request
Aug 10, 2017
This was referenced Oct 2, 2017
This was referenced Feb 2, 2018
This was referenced Aug 26, 2019
This was referenced Sep 4, 2019
This was referenced Sep 22, 2019
This was referenced Jan 22, 2020
This was referenced Jan 23, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced Mar 27, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9594. Long term, we can ignore this sort of stuff, but the attribute white list change hasn't landed (will it for 15.x?).
Testing:
I've hoisted this build of React on surge.sh and setup a fiddle:
https://jsfiddle.net/84v837e9/88/
The video tag should correctly receive the controlList attribute.
More info: