15.6.2 Release Prep #10430

nhunzaker · 2017-08-10T16:46:03Z

Commits

ChangeEventPlugin.js IE detection is broken on Chrome/Safari/FF etc Use boolean assertion for documentMode check #10032
No error when element with ref created in another elements constructor in dev environment Creating element with ref in constructor does not throw error in dev mode (#9635) #10025
Treat columns property as a unitless number Treat columns property as a unitless number #10115
move augmentClass definition above SyntheticEvent Proxy replacement move augmentClass definition above SyntheticEvent Proxy replacement #10011
Use a closure to bind argument to callback in ReactErrorUtils Use a closure to bind argument to callback in ReactErrorUtils #8363
Fix uncontrolled radios Fix uncontrolled radios #10156
Add controlList to DOM property whitelist Add controlList to DOM property whitelist #9940

Documentation

Changelog
Documentation updates

Misc

Update lockfile
Version bump

* Use a closure to bind gaurded callback This way the fake event isn't being implicitly passed into the event handler * Add tests for ReactErrorUtils Add fiber test report Linting fixes

See: - https://github.com/WICG/controls-list/blob/gh-pages/explainer.md - https://developers.google.com/web/updates/2017/03/chrome-58-media-updates#controlslist

nhunzaker · 2017-08-10T18:30:05Z

@aweary @flarnie I think this is good to go, I think the only outstanding tasks beyond deployment are to update the static markup for the website and ship to Bower.

But this PR cherry picks the commits we want (aside from #10025, which we need to figure out) and sets up everything else.

gaearon · 2017-08-12T10:45:06Z

Is anything blocking #10025? I left a comment there: #10025 (comment). I think if that change is made (and code only touches Stack rather than Fiber) then the change is good and we should get it in.

colebowl · 2017-08-14T20:26:04Z

@gaearon - It looks like @iansu has done the rebase in issue #10025 and is passing all tests.

iansu · 2017-08-14T21:11:35Z

I didn't think to comment in this thread. I have reverted the Fiber changes and updated my tests. Everything is passing.

I've been trying not to bug Dan because I think he's on vacation. 😀

nhunzaker · 2017-08-15T13:43:06Z

Awesome. @iansu thanks!

nhunzaker · 2017-08-15T13:44:26Z

src/renderers/shared/stack/reconciler/__tests__/refs-test.js

+      __DEV__ = originalDev;
+      process.env.NODE_ENV = originalEnv;
+    }
+  });


Controlling for process.env.NODE_ENV is new here. Otherwise, I was unable to get the invariant to minify the warning.

The way it is written here will break other things in non-trivial way. Please check ReactDOMProduction for example of test that overrides process.env.

In fact it would be great if you could send a PR to master that fixes DEV override to work same way as in ReactDOMProduction-test.

It will be done.

Okay, I've done that in 26722ce and added a TODO to follow up with a similar change on master.

nhunzaker · 2017-08-15T13:45:41Z

Everything checked off. I believe this is good to go.

iansu · 2017-08-15T15:10:01Z

CHANGELOG.md

+* Prevent event handlers from receiving extra argument (dev only) ([@aweary](https://github.com/aweary) in [#10115](https://github.com/facebook/react/pull/8363)
+* Fix cases where onChange would not fire with defaultChecked on radio inputs ([@jquense](https://github.com/jquense) in [#10156](https://github.com/facebook/react/pull/10156))
+* Add support for controlList attribute to DOM property whitelist ([@nhunzaker](https://github.com/nhunzaker) in [#9940](https://github.com/facebook/react/pull/9940))
+* Fix a bug where creating an element with a ref in a constructor threw an error in dev mode ([@iansu](https://github.com/iansu) in [#10025](https://github.com/facebook/react/pull/10025))


This description is wrong. The bug was that creating an element with a ref in a constructor did NOT throw an error in dev mode.

🙈 Thank you.

Got it in da62f42

colebowl · 2017-08-17T14:30:17Z

@aweary - Would you be able to complete the requested review?

@iansu - Are there any other steps we need to complete before this can be merged?

ssilve1989 · 2017-08-25T18:52:18Z

Any update when this will be available? I'm looking to get the fixes for uncontrolled radio buttons.

aweary

LGTM, pending the process.env.NODE_ENV stuff @nhunzaker and @gaearon were discussing.

manikandasankar · 2017-08-28T10:54:01Z

Any update when this will be available?
I am struck with this issue ChangeEventPlugin.js IE detection is broken

colebowl · 2017-09-05T15:27:51Z

Hi @gaearon / @aweary / @nhunzaker,

I know you guys aren't actively working on this branch as you're working on on the next version but I was wondering if it would be possible to get this wrapped up and merged? There are several folks waiting on this to fix issues in their app (including us).

If there is any more action that needs to be taken, I'd be more than happy take the lead to get this done.

Thanks!

nhunzaker · 2017-09-06T13:33:58Z

@colebowl Thanks for the prod, and I am sorry it was necessary.

I've updated the ref test to use the recommended code and I've updated the timestamps on the changelog and blog post.

This should be good to go, but I'll be out of pocket the rest of the day. I'm happy to review any updates if we need to change anything. I'll circle back later tonight.

gaearon · 2017-09-25T20:34:20Z

We'll need to get the LICENSE change rolled here. Plan to get it out tomorrow.

sophiebits · 2017-09-25T20:45:46Z

I can just do it after merging this. Probably easiest that way.

… Only set ReactCurrentOwner.current in dev mode when the component has no constructor. (#10025) nhunzaker: I've added an additional line to the ref test that sets the NODE_ENV invironment variable. This allows the test to pass.

Add columns to isUnitlessNumber list

16ed333

facebook-github-bot added the CLA Signed label Aug 10, 2017

walrusfruitcake and others added 3 commits August 10, 2017 12:48

move augmentClass definition above SyntheticEvent Proxy replacement (#…

dec3ed1

…10011)

Use a closure to bind argument to callback in ReactErrorUtils (#8363)

3c55d12

* Use a closure to bind gaurded callback This way the fake event isn't being implicitly passed into the event handler * Add tests for ReactErrorUtils Add fiber test report Linting fixes

Add controlList to DOM property whitelist (#9940)

c802f94

See: - https://github.com/WICG/controls-list/blob/gh-pages/explainer.md - https://developers.google.com/web/updates/2017/03/chrome-58-media-updates#controlslist

nhunzaker force-pushed the 15.6.2-dev branch from 5c3573c to c802f94 Compare August 10, 2017 17:35

nhunzaker requested a review from aweary August 10, 2017 17:35

nhunzaker added 2 commits August 10, 2017 13:41

Update yarn.lock file

f8afe83

Add 15.6.2 changelog

31ada74

nhunzaker force-pushed the 15.6.2-dev branch from 9925ec9 to 31ada74 Compare August 10, 2017 17:58

Update React version in docs

c08911c

nhunzaker force-pushed the 15.6.2-dev branch from a7a7bc5 to 0dd799a Compare August 10, 2017 18:25

nhunzaker commented Aug 15, 2017

View reviewed changes

nhunzaker force-pushed the 15.6.2-dev branch from c088023 to b953756 Compare August 15, 2017 14:04

iansu reviewed Aug 15, 2017

View reviewed changes

aweary approved these changes Aug 25, 2017

View reviewed changes

Add 15.6.2 blog post

8af9dbf

iansu and others added 11 commits September 25, 2017 17:02

Update release date

b2185d7

Update changelog with #10025

fe69ea4

Improve grammar on changelog #10025 entry

06d2556

Correct ref warning entry in changelog

e0c864d

Use standard method of testing for production

cc9d64c

Update timestamps on post and changelog

5be8f5f

Update timestamps

8389371

15.x: File headers BSD+Patents -> MIT

080db9d

15.x: BSD+Patents -> MIT

8c3cece

15.6.2

5634f0d

sophiebits force-pushed the 15.6.2-dev branch from f69d2ef to 5634f0d Compare September 26, 2017 00:03

sophiebits merged commit 5634f0d into 15.6-dev Sep 26, 2017

MichaelDeBoey mentioned this pull request Sep 26, 2017

React 15.6.2 Umbrella #10040

Closed

12 tasks

gaearon deleted the 15.6.2-dev branch October 6, 2017 21:57

nhunzaker mentioned this pull request Nov 16, 2017

Preparing 15.6.3 #11573

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

15.6.2 Release Prep #10430

15.6.2 Release Prep #10430

nhunzaker commented Aug 10, 2017 •

edited

nhunzaker commented Aug 10, 2017

gaearon commented Aug 12, 2017

colebowl commented Aug 14, 2017

iansu commented Aug 14, 2017

nhunzaker commented Aug 15, 2017

nhunzaker Aug 15, 2017

gaearon Aug 15, 2017

gaearon Aug 15, 2017

nhunzaker Aug 15, 2017

nhunzaker Sep 6, 2017

nhunzaker commented Aug 15, 2017

iansu Aug 15, 2017

nhunzaker Aug 15, 2017

nhunzaker Aug 15, 2017

colebowl commented Aug 17, 2017

ssilve1989 commented Aug 25, 2017

aweary left a comment

manikandasankar commented Aug 28, 2017

colebowl commented Sep 5, 2017

nhunzaker commented Sep 6, 2017

gaearon commented Sep 25, 2017

sophiebits commented Sep 25, 2017

15.6.2 Release Prep #10430

15.6.2 Release Prep #10430

Conversation

nhunzaker commented Aug 10, 2017 • edited

Commits

Documentation

Misc

nhunzaker commented Aug 10, 2017

gaearon commented Aug 12, 2017

colebowl commented Aug 14, 2017

iansu commented Aug 14, 2017

nhunzaker commented Aug 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nhunzaker commented Aug 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colebowl commented Aug 17, 2017

ssilve1989 commented Aug 25, 2017

aweary left a comment

Choose a reason for hiding this comment

manikandasankar commented Aug 28, 2017

colebowl commented Sep 5, 2017

nhunzaker commented Sep 6, 2017

gaearon commented Sep 25, 2017

sophiebits commented Sep 25, 2017

nhunzaker commented Aug 10, 2017 •

edited