Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ControlList API's controlList attribute #9594

Closed
raglan-road opened this issue May 3, 2017 · 14 comments
Closed

Add support for ControlList API's controlList attribute #9594

raglan-road opened this issue May 3, 2017 · 14 comments

Comments

@raglan-road
Copy link

In version 58, Chrome shipped support for the HTMLMediaElement ControlList API and, by extension, the controlList attribute on elements like video and audio. Here's how the attribute looks in practice.

React <= 15.5.4 does not support this attribute and strips it out with a Warning: Unknown prop controlsList on <video> tag. Remove this prop from the element. warning in the console.

Could you add support for this new attribute? This isn't a pressing issue as it's possible to set the attribute via javascript (i.e. by setting it in a ref or in a component lifecycle event), but it would be nice to have it recognized as the valid attribute it is.

@raglan-road raglan-road changed the title Add support for ControlList API and controlList attribute Add support for ControlList API's controlList attribute May 3, 2017
@mikecx
Copy link

mikecx commented May 4, 2017

Just ran into this today as well but inside a stateless/pure component so the ref/lifecycle events really wont work.

@arsduo
Copy link

arsduo commented May 22, 2017

Ran into the same issue today. Support for this (and/or a standardized way to specify unknown props as HTML attributes as described in #7311 etc.) would be awesome.

@nhunzaker
Copy link
Contributor

@arsduo I'll reference this issue in the description of my PR so that we can be sure to circle back to this issue when it merges.

@arsduo
Copy link

arsduo commented May 22, 2017 via email

@Nopzen
Copy link

Nopzen commented May 29, 2017

Ran into this issue aswell, would be amazing to have this!

@nhunzaker
Copy link
Contributor

Ah I might have misdiagnosed this. @rickyH is right, it looks like we just need to add these to a whitelist. I'll throw together a PR and get something up for testing.

@nhunzaker
Copy link
Contributor

Done in #9940. I've also put up a jsfiddle if anyone doesn't mind taking a gander to make sure I haven't missed something:

https://jsfiddle.net/84v837e9/88/

@nhunzaker
Copy link
Contributor

Merged the addition. I've also sent out a pull request to ship it in the next minor release:
#9941

@uncleramsay
Copy link

Do we know when this will be released?

@nhunzaker
Copy link
Contributor

Good question. I just brought it up in the 15.6.2 release umbrella issue (#10040)

@nhunzaker
Copy link
Contributor

I've put it into the queue for 15.6.2

@sassanh
Copy link
Contributor

sassanh commented Aug 3, 2017

Do you have an estimate for when 15.6.2 will be out?
Also do you know if this is solved in 16 beta?

@aweary
Copy link
Contributor

aweary commented Oct 4, 2017

This is fixed in 16 and was released in 15.6.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants