Normalize file paths for require context on Windows #876

byCedric · 2022-09-28T22:42:15Z

Summary

On Windows, the require.context resolves modules to non-posix paths. This seems to diverge from the expected behavior compared to Webpack, where the modules are resolved as posix paths. Because of this, we are running into unfortunate issues like expo/router#13.

When inspecting the contextModuleTemplates, using this example repo, you can see this happening.

This change normalizes the file path keys to be posix, matching the default Webpack behavior. It does not change the absolute file reference. (based on this piece of code)

Test plan

Added a windows style test case, copied from this test in metro-file-map
Ran the tests on my local Windows machine
Patched the test repo with this change and validated the output on Windows

facebook-github-bot · 2022-09-29T09:37:04Z

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jacdebug

Thanks for the PR, looks good some little suggestions.

jacdebug · 2022-09-29T10:14:48Z

packages/metro/src/lib/contextModuleTemplates.js

@@ -34,6 +34,10 @@ function createFileMap(
      if (!filePath.startsWith('.')) {
        filePath = `.${path.sep}` + filePath;
      }
+      // NOTE(byCedric): On Windows, normalize the backslashes to forward slashes to match the behavior in Webpack.
+      if (path.sep === '\\') {


Lets use os.platform here

Suggested change

if (path.sep === '\\') {

if (os.platform === 'win32') {

Also by using os.platform you can remove the comment as code itself is self explanatory.

nit: If we move this logic above the preceding if statement, it's slightly cleaner to have normalised filePath first, before operating on it (e.g. adding relative path prefix).

Done and done

Does Metro have a standard way of mocking os.platform() to be win32? I'd prefer to add a test that runs in "windows mode" because I don't think there is a windows CI runner on Metro atm.

Not AFAIK, but can be achieved with Jest mocks. I think the added unit test makes sense — it's an intentional and direct test against the fork in logic implemented. IMO (weakly held, see below) it's nice that the base tests deal without the concern of POSIX/Windows paths except where we expect specific handling.

At the same time, we would harden test coverage if all tests ran for both path types, however this will not be solved immediately via a separate win32 test runner — as the input strings to all tests would need to be changed appropriately (and at which point could be handled on a Unix host). I guess we could explore some abstractions, possibly:

Simple: describe.each() (inside an abstraction) across suitable sets of tests for "posix paths" and "win32 paths" which mock relevant os and path methods in the win32 case, and the use of path.normalize() for every input string in these tests (and snapshot/path.sep-aware assertions).

What we get: All test cases are run at development time. Tests and snapshot tests are cleanly grouped by path behaviour (where use of path.normalize() alone will cause snapshot mismatches across platforms).

Fancy: Setting up "posix paths" and "win32 paths" globally for certain tests matching an extension pattern (e.g. .multiplatform.test.js, akin to the multiplatform Jest setup of jest-expo/universal — with output like this). In this case, we might opt to label these "unix" and "win32 (simulated)" with a wider set of mocked differences.

Improvements: More transparent behaviour when opted-in via test filename (no extra describe wrapper, snapshots automatically suffixed). Fancy CLI output for test cases (platform tag). Single source of truth for handling in test setup scripts. When actually running on Windows, would run only "win32" test suite (and dropping "(simulated)" suffix in CLI output).

With these ideas listed out, you might agree that our existing case-by-case handling is simple and adequate 😅.

Of course, this is not the only functional difference we may encounter on Windows, so I'm in favour of adding a win32 CI test job as a baseline. cc @motiz88

packages/metro/src/lib/contextModuleTemplates.js

packages/metro/src/lib/__tests__/contextModuleTemplates-test.js

dmytrorykun · 2022-09-30T10:35:59Z

@byCedric could you please rebase your branch a the latest main

packages/metro/src/lib/contextModuleTemplates.js

byCedric · 2022-09-30T13:07:01Z

@byCedric could you please rebase your branch a the latest main

Done! @dmytrorykun 😄

byCedric · 2022-09-30T17:10:52Z

Done! @dmytrorykun 😄

Done again! @dmytrorykun 😄

facebook-github-bot · 2022-09-30T17:17:13Z

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dmytrorykun · 2022-10-03T13:50:28Z

@byCedric could you please rebase your branch on the latest main once again

byCedric · 2022-10-03T15:29:21Z

@byCedric could you please rebase your branch on the latest main once again

Done @dmytrorykun, but can we please get this merged before the next change? 😄

Co-authored-by: Alex Hunt <hello@alexhunt.io>

facebook-github-bot · 2022-10-04T10:14:42Z

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…rsions Summary: Enables Windows test runs in CircleCI. Partially resolves this discussion: facebook#876 (comment). - Adds `test-windows` job via the `circleci/windows` orb (inspired by the main react-native repo CircleCI config: https://fburl.com/hxyx4han). - `test-linux` job continues to use fast `cimg/node` images. - Parametarises `node-version` on the `test-linux` and `test-windows` jobs, and assigns as a matrix of versions (remains a single run against `14.17.0` for now). - Drops the `yarn_run` command in favour of YAML anchor to explicitly mix in `&secure_unset_publish_token` behaviour using CircleCI's `environment` option, which is cross platform (see test plan). NOTE: Since Windows tests are failing en masse, the branch filter `only: /windows\/.*/` is added, effectively disabling this job except on `windows/`-prefixed branches (which will provide a hook for fixing these in future). ``` Test Suites: 18 failed, 92 passed, 110 total Tests: 232 failed, 1 skipped, 1286 passed, 1519 total Snapshots: 20 failed, 403 passed, 423 total Time: 87.927 s Ran all test suites. ``` Changelog: [Internal] Differential Revision: D40805193 fbshipit-source-id: a86689f6fc864483c12677e573df5c287aa63181

…rsions (#885) Summary: Pull Request resolved: #885 Enables Windows test runs in CircleCI. Partially resolves this discussion: #876 (comment). - Adds `test-windows` job via the `circleci/windows` orb (inspired by the main react-native repo [CircleCI config](https://github.com/facebook/react-native/blob/ad5e3f6b9ae870cbfcef2874511915c5dc309ce8/.circleci/config.yml#L960-L962)). - `test-linux` job continues to use fast `cimg/node` images. - Parametarises `node-version` on the `test-linux` and `test-windows` jobs, and assigns as a matrix of versions (remains a single run against `14.17` for now). - Drops the `yarn_run` command in favour of YAML anchor to explicitly mix in `&secure_unset_publish_token` behaviour using CircleCI's `environment` option, which is cross platform (see test plan). NOTE: Since Windows tests are failing en masse, the branch filter `only: /windows\/.*/` is added, effectively disabling this job except on `windows/`-prefixed branches (which will provide a hook for fixing these in future). ``` Test Suites: 18 failed, 92 passed, 110 total Tests: 232 failed, 1 skipped, 1286 passed, 1519 total Snapshots: 20 failed, 403 passed, 423 total Time: 87.927 s Ran all test suites. ``` https://app.circleci.com/pipelines/github/huntie/metro/9/workflows/2d5be9e2-40bf-4dc1-a450-621656f3cfc4/jobs/25 Changelog: [Internal] Reviewed By: jacdebug Differential Revision: D40805193 fbshipit-source-id: 011e1937c909deaa013bb6257a6a3df181f31e86

….0 (#264) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [metro-react-native-babel-preset](https://togithub.com/facebook/metro) | [`^0.72.0` -> `^0.76.0`](https://renovatebot.com/diffs/npm/metro-react-native-babel-preset/0.72.3/0.76.0) | [![age](https://badges.renovateapi.com/packages/npm/metro-react-native-babel-preset/0.76.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/metro-react-native-babel-preset/0.76.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/metro-react-native-babel-preset/0.76.0/compatibility-slim/0.72.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/metro-react-native-babel-preset/0.76.0/confidence-slim/0.72.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>facebook/metro</summary> ### [`v0.76.0`](https://togithub.com/facebook/metro/releases/tag/v0.76.0) [Compare Source](https://togithub.com/facebook/metro/compare/v0.75.1...v0.76.0) - **\[Breaking]**: Increase minimum Node version from 14 to 16. (facebook/metro@e5950ae by [@huntie](https://togithub.com/huntie)) - **\[Breaking]**: Remove `isAssetFile` from custom resolver context, add `assetExts`. (facebook/metro@c6548f7 by [@huntie](https://togithub.com/huntie)) - **\[Feature]**: Support [`require.resolveWeak()`](https://facebook.github.io/metro/docs/module-api#requireresolveweak). (facebook/metro@354d6e4 by [@motiz88](https://togithub.com/motiz88)) - **\[Fix]**: Don't over-invalidate on symlink changes if resolution through symlinks is not enabled. (facebook/metro@2303c10 by [@robhogan](https://togithub.com/robhogan)) - **\[Fix]**: Returning `false` from [`context.redirectModulePath`](https://facebook.github.io/metro/docs/resolution#redirectmodulepath-string--string--false) will resolve to empty module in all cases. (facebook/metro@0f1846a by [@huntie](https://togithub.com/huntie)) - **\[Fix]**: Respect extensionless entries in `browser`, `react-native` etc when resolving subpath package specifiers. (facebook/metro@7e92227 by [@huntie](https://togithub.com/huntie)) - **\[Fix]**: Remove undocumented Meta-only `__jsResource` and `__conditionallySplitJsResource` functions from module API. (facebook/metro@f1d905b and facebook/metro@69c8fc7 by [@motiz88](https://togithub.com/motiz88)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]**: Fixes and improvements for symlink support. (facebook/metro@0e2a70a, facebook/metro@3bef954, and facebook/metro@eeb211f by [@robhogan](https://togithub.com/robhogan)) - **\[Experimental]**: Fix bug where `"exports"` field would be used on relative imports within a package. (facebook/metro@cd25c2b by [@huntie](https://togithub.com/huntie)) ### [`v0.75.1`](https://togithub.com/facebook/metro/releases/tag/v0.75.1) [Compare Source](https://togithub.com/facebook/metro/compare/v0.75.0...v0.75.1) - **\[Feature]**: `metro-inspector-proxy`: Add a human-readable reference to each inspector entries/pages.([facebook/metro#921 by [@byCedric](https://togithub.com/byCedric)) - **\[Feature]**: `metro-inspector-proxy`: Report errors in the console. (facebook/metro@da8b41b by [@mattbfb](https://togithub.com/mattbfb)) - **\[Fix]**: Race condition where a very recently modified file might have missing metadata.(facebook/metro@baf28ab by [@robhogan](https://togithub.com/robhogan)) - **\[Fix]**: Source maps may have invalid entries when using Terser minification. ([facebook/metro#928 by [@robhogan](https://togithub.com/robhogan)) - **\[Fix]**: `metro-inspector-proxy`: Fetch source maps from Metro. (facebook/metro@6690b39 by [@mattbfb](https://togithub.com/mattbfb)) - **\[Fix]**: Mitigate potential source map mismatches with concurrent transformations due to [terser#1341](https://togithub.com/terser/terser/issues/1341). ([facebook/metro#929 by [@robhogan](https://togithub.com/robhogan)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]**: Add initial_build annotation to Resolving and Transforming Dependencies (facebook/metro@fc83b52 by [@blakef](https://togithub.com/blakef)) - **\[Experimental]**: Implement support for Package Exports (enabled via `resolver.unstable_enablePackageExports`) (facebook/metro@4d7ab38, facebook/metro@38b96f8, facebook/metro@216d3e2, facebook/metro@6e6f36f by [@huntie](https://togithub.com/huntie)) - **\[Experimental]**: Implement support for symlinks (enabled via `resolver.unstable_enableSymlinks`) ([facebook/metro#925, [facebook/metro#926, etc. by [@robhogan](https://togithub.com/robhogan)) **Full Changelog:** facebook/metro@v0.75.0...v0.75.1 ### [`v0.75.0`](https://togithub.com/facebook/metro/releases/tag/v0.75.0) [Compare Source](https://togithub.com/facebook/metro/compare/v0.74.1...v0.75.0) - **\[Breaking]**: Formalise minimum Node JS requirement at 14.17.0 via `package.json#engines`. (facebook/metro@c3e453e) - **\[Breaking]**: Filter untyped context properties passed to custom resolvers. (facebook/metro@cb01ec0) - **\[Breaking]**: Change default `context.redirectModulePath` implementation to return absolute path in all cases. (facebook/metro@acbfe63) - **\[Feature]**: Add `mainFields`, `getPackage`, and `getPackageForModule` to custom resolver context. (facebook/metro@adfb593) **Full Changelog**: facebook/metro@v0.74.1...v0.75.0 ### [`v0.74.1`](https://togithub.com/facebook/metro/releases/tag/v0.74.1) [Compare Source](https://togithub.com/facebook/metro/compare/v0.74.0...v0.74.1) - **\[Feature]**: Add `@babel/plugin-proposal-numeric-separator` to `metro-react-native-babel-preset` ([facebook/metro#681 by [@SConaway](https://togithub.com/SConaway)) **Full Changelog**: facebook/metro@v0.74.0...v0.74.1 ### [`v0.74.0`](https://togithub.com/facebook/metro/releases/tag/v0.74.0) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.8...v0.74.0) - **\[Breaking]** Remove [@babel/plugin-transform-template-literals](https://togithub.com/babel/plugin-transform-template-literals) from metro-react-native-babel-preset (facebook/metro@322dea8) - **\[Breaking]** Remove `postProcessBundleSourcemap` from config (facebook/metro@339794e) - **\[Fix]** Don't log ENOENT errors to console for expected URL stack frames (facebook/metro@1031ae6) - **\[Fix]** Don't attempt to use the `find` crawler on Windows (facebook/metro@735aa9f) - **\[Performance]** Improve AST processing during transformation ([facebook/metro#854 by [@EvanBacon](https://togithub.com/EvanBacon)) - **\[Performance]** Improve Fast Refresh responsiveness when watching a large number of files (facebook/metro@b942eca) **Full Changelog:** facebook/metro@v0.73.6...v0.74.0 ### [`v0.73.8`](https://togithub.com/facebook/metro/releases/tag/v0.73.8) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.7...v0.73.8) *This is a hotfix on the `0.73.x` branch.* - **\[Fix]**: Source maps may have invalid entries when using Terser minification. ([facebook/metro#928) - **\[Fix]**: Mitigate potential source map mismatches with concurrent transformations due to [terser#1341](https://togithub.com/terser/terser/issues/1341). ([facebook/metro#929) **Full Changelog**: facebook/metro@v0.73.7...v0.73.8 ### [`v0.73.7`](https://togithub.com/facebook/metro/releases/tag/v0.73.7) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.6...v0.73.7) *This is a hotfix on the `0.73.x` branch.* - **\[Fix]** Don't attempt to use the `find` crawler on Windows (facebook/metro@3703019) ### [`v0.73.6`](https://togithub.com/facebook/metro/releases/tag/v0.73.6) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.5...v0.73.6) - **\[Fix]** Fix duplicate 'add' events, reduce dropped events on new subtrees in `NodeWatcher` (non-Watchman, non-macOS).(facebook/metro@51fb7e3) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]** `experimentalImportBundleSupport`: Move bundle path hints into serialised dependency map([facebook/metro#901) **Full Changelog:** facebook/metro@v0.73.5...v0.73.6 ### [`v0.73.5`](https://togithub.com/facebook/metro/releases/tag/v0.73.5) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.4...v0.73.5) - **\[Fix]**: Make all `getTransformOptions` result properties optional. (facebook/metro@a07c823) - **\[Fix]**: Bug that can lead to "unknown module" errors at runtime after an incremental build. (facebook/metro@b1be263) - **\[Fix]**: `metro-runtime`: Re-throw cached module errors without wrapping. (facebook/metro@032c4a1) - **\[Fix]** Bump `babel/types` dependency to `^7.20.0` for more consistent exposed AST Bump `babel/types` dependency to `^7.20.0` for more consistent exposed AST **Full Changelog**: facebook/metro@v0.73.4...v0.73.5 ### [`v0.73.4`](https://togithub.com/facebook/metro/releases/tag/v0.73.4) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.3...v0.73.4) - **\[Feature]:** Expose `watch` option in `RunServerOptions` ([facebook/metro#889 by [@EvanBacon](https://togithub.com/EvanBacon)) - **\[Feature]:** `metro-runtime`: Emit additional context on WebSocket `'close'` events (facebook/metro@d54986c) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]**: `experimentalImportBundleSupport`: Retraverse parents of deleted async dependencies (facebook/metro@cb806d1) **Full Changelog:** facebook/metro@v0.73.3...v0.73.4 ### [`v0.73.3`](https://togithub.com/facebook/metro/releases/tag/v0.73.3) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.2...v0.73.3) - **\[Feature]**: Add configurable watcher health check that is off by default (facebook/metro@7adf468, facebook/metro@39f6e50) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]**: Move `experimentalImportBundleSupport` option from transformer to server (facebook/metro@3c0e1f7) **Full Changelog:** facebook/metro@v0.73.2...v0.73.3 ### [`v0.73.2`](https://togithub.com/facebook/metro/releases/tag/v0.73.2) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.1...v0.73.2) Maintenance release with purely internal changes. **Full Changelog:** facebook/metro@v0.73.1...v0.73.2 ### [`v0.73.1`](https://togithub.com/facebook/metro/releases/tag/v0.73.1) [Compare Source](https://togithub.com/facebook/metro/compare/v0.73.0...v0.73.1) - **\[Fix]**: Generate a unique name for each Watchman subscription. ([`3b0e78a`](https://togithub.com/facebook/metro/commit/3b0e78a76f4eea9f02e8b8464cf5b5e4549d6ac7)) > NOTE: Experimental features are not covered by semver and can change at any time. - **\[Experimental]\[Fix]**: Normalize file paths for `require.context` on Windows ([facebook/metro#876 by [@byCedric](https://togithub.com/byCedric)) **Full Changelog:** facebook/metro@v0.73.0...v0.73.1 ### [`v0.73.0`](https://togithub.com/facebook/metro/releases/tag/v0.73.0) [Compare Source](https://togithub.com/facebook/metro/compare/v0.72.3...v0.73.0) - **\[Breaking]** Switch default minifier from `uglify-es` to `terser`. ([#871](https://togithub.com/facebook/metro/issues/871)) - **\[Breaking]**: Increase minimum supported Node.js version to ^14.17.0. ([#872](https://togithub.com/facebook/metro/issues/872)) - **\[Breaking]**: Drop support for old (pre-CalVer) Watchman versions. ([`422055a`](https://togithub.com/facebook/metro/commit/422055a5ccaca41edb1864ca07d4f810b3e03791)) - **\[Feature]**: Support `fsevents` watcher on Apple Silicon. ([#875](https://togithub.com/facebook/metro/issues/875)) - **\[Feature]**: Support loading source URLs in inspector-proxy. ([`db19b06`](https://togithub.com/facebook/metro/commit/db19b06bdd6d2fbbe109e4f3be4b3af3489c1f1c)) - **\[Fix]**: Log warning on unexpected error during `metro-file-map` cache read. ([`7028b7f`](https://togithub.com/facebook/metro/commit/7028b7f51074f9ceef22258a8643d0f90de2388b)) - **\[Fix]**: Remove exponentiation operator transform from `metro-react-native-babel-preset`. ([`c2365bb`](https://togithub.com/facebook/metro/commit/c2365bb1d72a3773b31c05feab13a96afac484df)) - **\[Fix]**: Don’t check `watchman --version` if `useWatchman` is false. ([`76c9307`](https://togithub.com/facebook/metro/commit/76c9307ed61efa7794b30b4e585cc5941ed73e16)) **Full Changelog:** facebook/metro@v0.72.3...v0.73.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab/dooboo-ui).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2022

byCedric force-pushed the @bycedric/require-context/normalize-paths-on-windows branch from 93cbefc to 42d200b Compare September 28, 2022 22:43

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 28, 2022

jacdebug requested changes Sep 29, 2022

View reviewed changes

jacdebug approved these changes Sep 29, 2022

View reviewed changes

byCedric force-pushed the @bycedric/require-context/normalize-paths-on-windows branch from 9641708 to 9f80195 Compare September 29, 2022 21:56

huntie reviewed Sep 30, 2022

View reviewed changes

packages/metro/src/lib/contextModuleTemplates.js Outdated Show resolved Hide resolved

byCedric force-pushed the @bycedric/require-context/normalize-paths-on-windows branch from 9f80195 to 2131e76 Compare September 30, 2022 13:05

byCedric force-pushed the @bycedric/require-context/normalize-paths-on-windows branch from e52b21b to 5fa03ad Compare September 30, 2022 17:10

byCedric force-pushed the @bycedric/require-context/normalize-paths-on-windows branch from 5fa03ad to 04a8509 Compare October 3, 2022 15:28

byCedric and others added 7 commits October 3, 2022 18:25

fix: normalize require.context paths to posix only

8ce0041

test: add windows to posix test case

ca6a7a7

refactor: use os.platform and slash

eda29fc

refactor: prioritize file path normalization

0acf64a

refactor: run prettier on context module template tests

db1765e

refactor: drop slash in favor of replace all

caff1ea

refactor: back to og replace with regex

17fc817

Co-authored-by: Alex Hunt <hello@alexhunt.io>

byCedric force-pushed the @bycedric/require-context/normalize-paths-on-windows branch from 04a8509 to 17fc817 Compare October 3, 2022 16:25

facebook-github-bot closed this in 4bace2a Oct 4, 2022

byCedric deleted the @bycedric/require-context/normalize-paths-on-windows branch October 4, 2022 15:28

huntie mentioned this pull request Oct 31, 2022

Add per-platform CI jobs to enable Windows tests, multiple Node.js versions #885

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normalize file paths for require context on Windows #876

Normalize file paths for require context on Windows #876

byCedric commented Sep 28, 2022 •

edited

facebook-github-bot commented Sep 29, 2022

jacdebug left a comment

jacdebug Sep 29, 2022

jacdebug Sep 29, 2022 •

edited

huntie Sep 29, 2022

byCedric Sep 29, 2022

byCedric Sep 29, 2022

huntie Sep 30, 2022 •

edited

dmytrorykun commented Sep 30, 2022

byCedric commented Sep 30, 2022 •

edited

byCedric commented Sep 30, 2022

facebook-github-bot commented Sep 30, 2022

dmytrorykun commented Oct 3, 2022

byCedric commented Oct 3, 2022 •

edited

facebook-github-bot commented Oct 4, 2022

Normalize file paths for require context on Windows #876

Normalize file paths for require context on Windows #876

Conversation

byCedric commented Sep 28, 2022 • edited

Summary

Test plan

facebook-github-bot commented Sep 29, 2022

jacdebug left a comment

Choose a reason for hiding this comment

jacdebug Sep 29, 2022

Choose a reason for hiding this comment

jacdebug Sep 29, 2022 • edited

Choose a reason for hiding this comment

huntie Sep 29, 2022

Choose a reason for hiding this comment

byCedric Sep 29, 2022

Choose a reason for hiding this comment

byCedric Sep 29, 2022

Choose a reason for hiding this comment

huntie Sep 30, 2022 • edited

Choose a reason for hiding this comment

dmytrorykun commented Sep 30, 2022

byCedric commented Sep 30, 2022 • edited

byCedric commented Sep 30, 2022

facebook-github-bot commented Sep 30, 2022

dmytrorykun commented Oct 3, 2022

byCedric commented Oct 3, 2022 • edited

facebook-github-bot commented Oct 4, 2022

byCedric commented Sep 28, 2022 •

edited

jacdebug Sep 29, 2022 •

edited

huntie Sep 30, 2022 •

edited

byCedric commented Sep 30, 2022 •

edited

byCedric commented Oct 3, 2022 •

edited