Add per-platform CI jobs to enable Windows tests, multiple Node.js versions #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D40805195 fbshipit-source-id: b0996abb1c47d5e93d266d492149ab568e3b8b51
Summary: - Relocate CircleCI config file - Set display name for `yarn_install` run step - Add `store_test_results` step to `test-node-14` job via the `jest-junit` reporter https://pxl.cl/2jcmh Differential Revision: D40805194 fbshipit-source-id: 3d16f8016c7ce2b5b458c94aa0e1f25578fbf4ac
Differential Revision: D40805192 fbshipit-source-id: c4b62d06575225e78dd261c62379878f1af5134a
…rsions Summary: Enables Windows test runs in CircleCI. Partially resolves this discussion: facebook#876 (comment). - Adds `test-windows` job via the `circleci/windows` orb (inspired by the main react-native repo CircleCI config: https://fburl.com/hxyx4han). - `test-linux` job continues to use fast `cimg/node` images. - Parametarises `node-version` on the `test-linux` and `test-windows` jobs, and assigns as a matrix of versions (remains a single run against `14.17.0` for now). - Drops the `yarn_run` command in favour of YAML anchor to explicitly mix in `&secure_unset_publish_token` behaviour using CircleCI's `environment` option, which is cross platform (see test plan). NOTE: Since Windows tests are failing en masse, the branch filter `only: /windows\/.*/` is added, effectively disabling this job except on `windows/`-prefixed branches (which will provide a hook for fixing these in future). ``` Test Suites: 18 failed, 92 passed, 110 total Tests: 232 failed, 1 skipped, 1286 passed, 1519 total Snapshots: 20 failed, 403 passed, 423 total Time: 87.927 s Ran all test suites. ``` Changelog: [Internal] Differential Revision: D40805193 fbshipit-source-id: a86689f6fc864483c12677e573df5c287aa63181
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40805193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables Windows test runs in CircleCI. Partially resolves this discussion: #876 (comment).
test-windowsjob via thecircleci/windowsorb (inspired by the main react-native repo CircleCI config).test-linuxjob continues to use fastcimg/nodeimages.node-versionon thetest-linuxandtest-windowsjobs, and assigns as a matrix of versions (remains a single run against14.17.0for now).yarn_runcommand in favour of YAML anchor to explicitly mix in&secure_unset_publish_tokenbehaviour using CircleCI'senvironmentoption, which is cross platform (see test plan).NOTE: Since Windows tests are failing en masse, the branch filter
only: /windows\/.*/is added, effectively disabling this job except onwindows/-prefixed branches (which will provide a hook for fixing these in future).https://app.circleci.com/pipelines/github/huntie/metro/9/workflows/2d5be9e2-40bf-4dc1-a450-621656f3cfc4/jobs/25
Changelog: [Internal]
Differential Revision: D40805193