Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): Add hebrew translations #4811

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 18, 2021

Motivation

Follow-up of #4587

Attempt to provide initial Hebrew translations, handling the review of the community

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local test

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label May 18, 2021
@slorber slorber requested a review from lex111 as a code owner May 18, 2021 12:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 18, 2021
@slorber slorber mentioned this pull request May 18, 2021
@netlify
Copy link

netlify bot commented May 18, 2021

[V1]

Built with commit 15b7043

https://deploy-preview-4811--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented May 18, 2021

[V2]

Built with commit 15b7043

https://deploy-preview-4811--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4811--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 640 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.4 kB 0 B
website/build/assets/js/main.********.js 463 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 26.9 kB 0 B

compressed-size-action

@slorber slorber merged commit ab19070 into master May 18, 2021
@slorber slorber deleted the slorber/hebrew-theme-translation branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants