fix(v2): Fix Hebrew translations #4815
Conversation
Change "2" form of plural type to not include 2 number in hebrew
|
Hi @nirtamir2! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
nirtamir2
changed the title
|
[V2] Built without sensitive environment variables with commit e086267 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4815--docusaurus-2.netlify.app/ |
| @@ -24,13 +24,13 @@ | |||
| "theme.blog.paginator.newerEntries": "הכי חדש", | |||
| "theme.blog.paginator.olderEntries": "ישן יותר", | |||
| "theme.blog.post.paginator.navAriaLabel": "רשימת חדשות של הבלוג", | |||
| "theme.blog.post.paginator.newerPost": "הכי חדש", | |||
There was a problem hiding this comment.
Fix from "The newest"
| "theme.CodeBlock.copy": "העתק", | ||
| "theme.CodeBlock.copyButtonAriaLabel": "העתק קוד", |
There was a problem hiding this comment.
Change from "to copy" to "copy" (in a form like "do copy" command)
| "theme.blog.tagTitle": "{nPosts} עם התג \"{tagName}\"", | ||
| "theme.common.editThisPage": "לערוך דף", | ||
| "theme.common.editThisPage": "ערוך דף זה", |
There was a problem hiding this comment.
"to edit page" => "edit this page" (in a form of command)
| "theme.docs.sidebar.expandButtonTitle": "פתח", | ||
| "theme.docs.sidebar.responsiveCloseButtonLabel": "לסגור תפריט", | ||
| "theme.docs.sidebar.responsiveOpenButtonLabel": "לפתוח תפריט", | ||
| "theme.docs.sidebar.responsiveCloseButtonLabel": "סגור תפריט", | ||
| "theme.docs.sidebar.responsiveOpenButtonLabel": "פתח תפריט", |
There was a problem hiding this comment.
Change from the action to open/top close to the command open / close
| "theme.docs.versions.latestVersionLinkLabel": "גרסא אחרונה", | ||
| "theme.docs.versions.latestVersionSuggestionLabel": "לדוקומנטאציה עדכנית, ראה {latestVersionLink} ({versionLabel}).", | ||
| "theme.docs.versions.unmaintainedVersionLabel": "דוקומנטאציה זו {siteTitle} {versionLabel}, כבר לא נתמכת.", | ||
| "theme.docs.versions.unreleasedVersionLabel": "דוקומנטאציה שעדיין לא יצאה לאוויר ל {siteTitle} {versionLabel} גרסא.", | ||
| "theme.lastUpdated.atDate": " בתאריך {date}", | ||
| "theme.lastUpdated.byUser": " על ידי {user}", | ||
| "theme.lastUpdated.lastUpdatedAtBy": "שונה{atDate}{byUser}", | ||
| "theme.lastUpdated.lastUpdatedAtBy": "עודכן{atDate}{byUser}", |
There was a problem hiding this comment.
Use more appropriate word:
Change => Update
|
[V2] Built without sensitive environment variables with commit e086267 |
nirtamir2
changed the title
nirtamir2
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks ! It's not like I'm able to review the changes, so let's merge 😅 |
Motivation
Following #4587 (comment) comment - This PR removes the Hebrew string for the number 2, and use it directly.
Example for English speakers:
Two posts => 2 postsbecause "post" in Hebrew does not have a special form for two (unlike other Hebrew words like "day" יום / יומיים / ימים).
Also - after running it locally I fix other inconsistent translations I found.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Test it locally
Related PRs
#4811