Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Amend Hebrew translations #4819

Merged
merged 1 commit into from
May 20, 2021

Conversation

liorheber
Copy link
Contributor

Motivation

Follow up on #4811
Fixing some of the translations based on the Hebrew Academy.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local test

Related PRs

#4811
#4587

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 20, 2021
@netlify
Copy link

netlify bot commented May 20, 2021

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4819--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 20, 2021
@slorber
Copy link
Collaborator

slorber commented May 20, 2021

thanks!

Going to merge

@nirtamir2 feel free to comment if something looks wrong to you

@nirtamir2
Copy link
Contributor

LGTM
עברית שפה קשה
😃

@slorber slorber merged commit db6f5ce into facebook:master May 20, 2021
@liorheber liorheber deleted the hebrew-theme-translations-fixes branch May 20, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants