Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ESLint cache file into node_modules #9977

Merged
merged 4 commits into from Dec 8, 2020
Merged

Move ESLint cache file into node_modules #9977

merged 4 commits into from Dec 8, 2020

Conversation

ehsankhfr
Copy link
Contributor

@ehsankhfr ehsankhfr commented Nov 1, 2020 •
edited by ianschmitz

Fix #9970
Fix #10161

As mentioned in #9977 (comment), likewise eslint-loader, we need to support non-existing OR inaccessible path fallback for cache folder into os.tempdir, as current(new) eslint plugin doesn't support the fallback.

TEST PLAN:

To test how permission issue folder fallback works:

  1. under the node_module
    • Remove the .cache folder content, if folder exists.
    • Or, create .cache folder
  2. run chmod u=r--,g=r--,o=r-- node_modules/.cache
  3. run npm start
  4. ls node_modules/.cache should not show the .eslintcache file

To test how non-existent folder fallback works:

  1. under the node_module
    • Remove the .cache folder content, if folder exists
  2. run npm start
  3. ls node_modules/.cache should not show the .eslintcache file

To test how normal flow of caching works:

  1. under the node_module
    1. Make sure the .cache folder exists
    2. Make sure there is enough access to the folder .cache: chmod u=rwx,g=r-x,o=r-x node_modules/.cache
  2. run npm start
  3. ls node_modules/.cache should show the .eslintcache file

@maxsbelt maxsbelt mentioned this pull request Nov 18, 2020
Merged
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 20, 2020
@apibrac
(MOB): Correct eslint use of cache
abcaf86 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 20, 2020
@apibrac
(MOB): Correct eslint use of cache
f0befdb 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 21, 2020
@apibrac
(MOB): Correct eslint use of cache
76e7372 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
fc52a43 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
030ce88 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
4495ca4 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
1c06efd 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
32e9171 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
@ianschmitz ianschmitz added this to the 4.0.2 milestone Nov 25, 2020
ianschmitz
ianschmitz suggested changes Nov 25, 2020
View reviewed changes
packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
@ianschmitz ianschmitz mentioned this pull request Nov 26, 2020
Closed
@StraightOuttaCrompton StraightOuttaCrompton mentioned this pull request Dec 2, 2020
Closed
@ianschmitz ianschmitz mentioned this pull request Dec 8, 2020
Closed
@ianschmitz
Copy link
Contributor

I simplified the impl. a fair bit. Here's some more context: eslint/eslint#11757

@ianschmitz ianschmitz changed the title fix: eslint cache destination folder change Move ESLint cache file into node_modules Dec 8, 2020
@ianschmitz ianschmitz merged commit e039ad3 into facebook:master Dec 8, 2020
@raix raix mentioned this pull request Dec 22, 2020
Closed
25 tasks
@cseas cseas mentioned this pull request Dec 30, 2020
Open
This was referenced Jan 12, 2021
Closed
Closed
garethsb added a commit to orfar1994/nmos-js that referenced this pull request Jan 15, 2021
@garethsb
Add .eslintcache to .gitignore, though this may be resolved by create…
e286d9b 
…-react-app/4.0.2 (see facebook/create-react-app#9977)
@ehsankhfr ehsankhfr deleted the eslint-cache-file branch January 19, 2021 16:20
@mrmckeb mrmckeb mentioned this pull request Jan 20, 2021
Closed
dimadk24 added a commit to dimadk24/english-fight-ui that referenced this pull request Feb 3, 2021
@dimadk24
chore: remove .eslintcache from gitignore
09d6116 
facebook/create-react-app/pull/9977
dimadk24 added a commit to dimadk24/english-fight-ui that referenced this pull request Feb 4, 2021
@dimadk24
chore: remove .eslintcache from gitignore
5db659f 
facebook/create-react-app/pull/9977
collinbarrett added a commit to collinbarrett/FilterLists that referenced this pull request Feb 4, 2021
@collinbarrett
Revert "fix(web): 🐛 gitignore .eslintcache"
7c51ca6 
This reverts commit e3116f1.

ref facebook/create-react-app#9977
@akaltar akaltar mentioned this pull request Feb 18, 2021
Open
@drich7449 drich7449 mentioned this pull request Feb 23, 2021
Open
@hzhz hzhz mentioned this pull request Feb 23, 2021
Open
@sirinartk sirinartk mentioned this pull request Feb 23, 2021
Closed
@nihaals nihaals mentioned this pull request Mar 5, 2021
Closed
@anitakym anitakym mentioned this pull request Apr 15, 2021
Closed
blackarctic added a commit to blackarctic/create-react-app that referenced this pull request Apr 29, 2021
@blackarctic @ryota-murakami
@KonstantinSimeonov @iansu @sho-t @anyulled @ianschmitz @jeffposnick @EvanBacon @trainto @sheepsteak @jasonwilliams @jabranr @jrr @raix @maxsbelt @ehsankhfr @merceyz @Avivhdr @tobiasbueschel @josezone @mad-jose @ajhyndman @mrmckeb @jamesgeorge007 @Awarua- @wclem4
Align with react-scripts 4.0.3 (#17)
109f05d 
* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921)

Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com>

* Add logo license to README

* Remove trailing space in reportWebVitals.ts (facebook#10040)

* docs: add React Testing Library as a library requiring jsdom (facebook#10052)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048)

* Create FUNDING.yml

* replace inquirer with prompts (facebook#10083)

- remove `react-dev-utils/inquirer` public import

* Prepare 4.0.1 release

* Prepare 4.0.1 release

* Publish

 - cra-template-typescript@1.1.1
 - cra-template@1.1.1
 - create-react-app@4.0.1
 - react-dev-utils@11.0.1
 - react-scripts@4.0.1

* chore: bump web-vital dependency version (facebook#10143)

* chore: bump typescript version (facebook#10141)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

* remove chalk from formatWebpackMessages (facebook#10198)

* Upgrade @svgr/webpack to fix build error (facebook#10213)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Improve vendor chunk names in development (facebook#9569)

* Update postcss packages (facebook#10003)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Recovered some integration tests (facebook#10091)

* Upgrade sass-loader (facebook#9988)

* Move ESLint cache file into node_modules (facebook#9977)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Revert "Update postcss packages" (facebook#10216)

This reverts commit 580ed5d.

* Remove references to Node 8 (facebook#10214)

* fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872)

* Update using-the-public-folder.md (facebook#10314)

Some library --> Some libraries

* docs: add missing override options for Jest config (facebook#9473)

* Fix CI tests (facebook#10217)

* appTsConfig immutability handling by immer (facebook#10027)

Co-authored-by: mad-jose <joset@yeswearemad.com>

* Add support for new BUILD_PATH advanced configuration variable (facebook#8986)

* Add opt-out for eslint-webpack-plugin (facebook#10170)

* Prepare 4.0.2 release

* Publish

 - cra-template-typescript@1.1.2
 - cra-template@1.1.2
 - create-react-app@4.0.2
 - react-dev-utils@11.0.2
 - react-error-overlay@6.0.9
 - react-scripts@4.0.2

* tests: update test case to match the description (facebook#10384)

* Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312)

Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs

* Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590)

* update immer to 8.0.1 to address vulnerability (facebook#10412)

Resolves facebook#10411

Bumps immer version to 8.0.1 to address the prototype pollution
vulnerability with the current 7.0.9 version.

* Prepare 4.0.3 release

* Update CHANGELOG

* Publish

 - create-react-app@4.0.3
 - react-dev-utils@11.0.3
 - react-scripts@4.0.3

Co-authored-by: Ryota Murakami <dojce1048@gmail.com>
Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com>
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
Co-authored-by: sho90 <aznecosann@gmail.com>
Co-authored-by: Anyul Rivas <anyulled@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Jeffrey Posnick <jeffy@google.com>
Co-authored-by: Evan Bacon <baconbrix@gmail.com>
Co-authored-by: Sahil Purav <sahil5684@gmail.com>
Co-authored-by: Hakjoon Sim <trainto@gmail.com>
Co-authored-by: Chris Shepherd <chris@chrisshepherd.me>
Co-authored-by: Jason Williams <936006+jasonwilliams@users.noreply.github.com>
Co-authored-by: Jabran Rafique⚡️ <jabranr@users.noreply.github.com>
Co-authored-by: John Ruble <johnruble@gmail.com>
Co-authored-by: Morten N.O. Nørgaard Henriksen <morten.n.o.henriksen@icloud.com>
Co-authored-by: Sergey Makarov <serega.s.makar@gmail.com>
Co-authored-by: EhsanKhaki <ehsankhfr@gmail.com>
Co-authored-by: Kristoffer K <merceyz@users.noreply.github.com>
Co-authored-by: Aviv Hadar <Avivhdr@gmail.com>
Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com>
Co-authored-by: mad-jose <44253495+josezone@users.noreply.github.com>
Co-authored-by: mad-jose <joset@yeswearemad.com>
Co-authored-by: Andrew Hyndman <ajhyndman@hotmail.com>
Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: Dion Woolley <woolley.dion@gmail.com>
Co-authored-by: Walker Clem <51654951+wclem4@users.noreply.github.com>
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@ehsankhfr @ianschmitz @wombleton
Move ESLint cache file into node_modules (facebook#9977)
a5ffcad 
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
@suraj-singh127 suraj-singh127 mentioned this pull request Apr 15, 2022
Closed
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
@ehsankhfr @ianschmitz @abhiisheek
Move ESLint cache file into node_modules (facebook#9977)
1af0fa7 
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@ehsankhfr @ianschmitz @abhiisheek
Move ESLint cache file into node_modules (facebook#9977)
1242835 
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3tr n3tr n3tr left review comments

@fangbinwei fangbinwei fangbinwei left review comments

@ianschmitz ianschmitz ianschmitz requested changes

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

.eslintcache constantly generated Change eslint loader cache location
5 participants
@ehsankhfr @ianschmitz @n3tr @fangbinwei @facebook-github-bot