Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .eslintcache in gitignore files for cra templates #10153

Closed
wants to merge 1 commit into from

Conversation

qria
Copy link

@qria qria commented Nov 26, 2020

ESlint generates a cache file that defaults to .eslintcache location.

Therefore the first thing people will encounter after running npm start is an untracked .eslintcache file generated. I believe this is not a desirable experience that CRA would want to provide.

Therefore I've added it into the .gitignore file.

@facebook-github-bot
Copy link

Hi @qria!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz
Copy link
Contributor

Thanks for the PR, but we will be instead moving the location of the cache file. It's in progress at #9977.

@ianschmitz ianschmitz closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants