Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .eslintcache #10346

Closed

Conversation

LauraBeatris
Copy link

Add .eslintcache to .gitignore file to disables its tracking. This file is unnecessary in the git tree.

Reference: #10161

@LauraBeatris
Copy link
Author

I've added it only to the root since the templates don't come with ESLint. Should we also ignore it on the templates?

@dudeisbrendan03
Copy link

This is honestly user-dependant if they use eslint.
It's like adding .vscode, .vs, .gitkraken or any other tool that creates a directory/files.
The user should add the products of their tools to the .gitignore

@LauraBeatris
Copy link
Author

@dudeisbrendan03 I agree that it's user-dependant on the template, but the root repo comes with ESLint

@dudeisbrendan03
Copy link

@dudeisbrendan03 I agree that it's user-dependant on the template, but the root repo comes with ESLint

See your point

@NMinhNguyen
Copy link
Contributor

I think this has already been solved (but not yet released) in #9977

@mrmckeb
Copy link
Contributor

mrmckeb commented Jan 20, 2021

Thanks @LauraBeatris, we've actually made the decision to move this cache so it won't clutter your directory anymore... look out for that in the next release!

See #9977

@mrmckeb mrmckeb closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants