New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade babel-loader to 8.2.1 #10123
Comments
Related storybook thread: storybookjs/storybook#13183 (comment) |
To disable the warning temporarily and be able to run storybook properly you can just pin |
To disable the warning temporarily, I just added the following flag to a But that's not a solution. That's just disabling the warning. |
Got the same warning but this time for 8.2.2
Also created .env file with |
I ended up with just manually installing babel-loader to the project. That seems to make the warning go away, and maybe that is a solution for cases like this. But the warning that react-scripts generates advises against this solution by clearly mentioning Instead straight up the warning should be "Try to install it manually if nothing else works". |
@shilman does Storybook require |
@marksy I believe
|
Thanks @shilman v6.1.12 fixed my issue 👍🏼 |
I'm still seeing this issue and confused by the fix - it doesn't matter that When I run react-app-ts@0.1.0 /Users/byronium/my-app
├─┬ @storybook/react@6.1.21
│ └─┬ @storybook/core@6.1.21
│ └── babel-loader@8.2.2
└─┬ react-scripts@4.0.3
└── babel-loader@8.1.0 as many other people have mentioned, resulting in the same error when I run There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.
The react-scripts package provided by Create React App requires a dependency:
"babel-loader": "8.1.0"
Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-loader was detected higher up in the tree:
/Users/byronium/my-app/node_modules/babel-loader (version: 8.2.2)
Manually installing incompatible versions is known to cause hard-to-debug issues.
If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.
... I've had to use storybookjs/storybook#4764 (comment) as a workaround. |
The reason for the error is that we are verifying a package versions that is higher up the tree. (#3771) (I think it's enough to verify only the package versions that react-scripts resolves with |
@Yama-Tomo is this something that is being changed in |
It seems to me this issue would be resolved if we changed this line to
Does anyone see a problem with doing that? |
Merge in BIAP/act-frontend from ~ODINS/act-frontend:feature/ARGUS-23872-update-dependencies to master Squashed commit of the following: commit e759c1a74ee2c42d29324d530702aadfec155adb Author: Odin Standal <odins@mnemonic.no> Date: Fri Jun 25 10:41:54 2021 +0200 ARGUS-23872 Update dependencies - babel-loader is set to 8.1.0 even though storybook uses a newer version, see facebook/create-react-app#10123 - reformat with prettier - bugfix: only close singleValueFilter when clicking outside - bugfix: fix cytoscape highlighting - bugfix: show WorkingHistory load progress when loading starts
What's the cause of not updating using Currently, you can't use CRA & Storybook without the flag |
Now, this issue did not come when use NPM as the package manager. With Yarn that issue still exists. |
can't CRA just upgrade to the latest babel-loader? |
npm install --save-dev @babel/core @babel/cli @babel/preset-env I am creating a library using CRA and want to install these babel dependencies, how can I know the exact compatible of these dependencies which are compatible with my CRA app? |
Bringing this issue back online since it is still not solved. Should I create a PR? |
personally, this issue is finally solved, since we've upgraded |
storybook has a conflict with cra due to versioning issues on babel loader and a faulty check on the cra side (see: storybookjs/storybook#13183 and facebook/create-react-app#10123 (comment)). this required either some hackery on the command side (by disabling preflight checks) or upgrading react-scripts to 5.0. as react scripts is not a direct dependency at runtime when serving our application, i opted for this approach. another issue that cropped up was postcss requiring version 8 due to transistive dependencies (design system -> chakra -> tailwind -> postcss). this was fixed by installing a direct dependency on postcss @ 8, which was the approach mentioned here: postcss/postcss-import#435. A dev mentioned that the API between 7/8 did not differ much and the release notes for 8 (https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users) also mentioned that there are no significant differences for end users, so this should be safe. tl;dr: build issues are fixed by upgrading dependencies. if you ever read this message, or any of the previous long commit messages, please drop me a :ultrafastparrot: thx
Fixed issue for me too 📈 |
Describe the bug
npm start
is giving me the following error:npm ls babel-loader
returns the following output:Did you try recovering your dependencies?
Yes
Which terms did you search for in User Guide?
babel-loader
Environment
Steps to reproduce
Run
npm start
in a CRA project after upgrading to @storybook/react@6.1.2Expected behavior
No errors
Actual behavior
npm start
throws error and doesn't run the applicationThe text was updated successfully, but these errors were encountered: