New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lower babel-loader required version everywhere #14811
lower babel-loader required version everywhere #14811
Conversation
Nx Cloud ReportCI ran the following commands for commit a84c879. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
This wont fix anything, There is no issue on Storybooks' end, it's an issue with how Ref #4764 (comment) |
@merceyz i don't think that's true. If you install react-scripts, which specifies exactly Babel-loader 8.1.0 in its package.json, then yarn/NPM should resolve a mutually compatible version for both requirements I believe, unless I'm mistaken. |
The issue we're addressing here, is that storybook's babel dependencies were too 'latest' compared to CRA's, lowering them means we allow for more versions-ranges, which means we allow the resolve to the same version as CRA. |
Looks like I was mistaken, when I tried it on a repo it did end up installing multiple versions and CRA complaining. But that said at least it's possible for me to modify my |
and to clarify, by too "latest" i mean that the current version of |
We should try to keep our version ranges in This will ensure we stay compatible with other tools as much as possible, and do not burden users with forcing them to upgrade other tools when they are not ready yet. With "as low as possible" I mean: - "babel-loader": "8.2.9",
+ "babel-loader": "8.0.0", Unless we actually depend on something that was introduced in "8.2.x" of course. But I think generally we're not. |
Also interested in this PR ! 🙏 (react-script/babel-loader conflict) |
A little bird told me CRA is going to drop this constraint in their next release |
@shilman either way might still be worth doing this (and may make sense for other deps too) just to minimize conflicting versions on install, that definitely makes it less urgent if it materializes though! |
facebook/create-react-app#10123 (comment) seems to indicate the specified version is what it is for a reason |
# Conflicts: # addons/graphql/package.json # addons/storyshots/storyshots-core/package.json # examples/riot-kitchen-sink/package.json # lib/core-server/package.json # yarn.lock
@ndelangen ping! |
# Conflicts: # addons/storyshots/storyshots-core/package.json # examples/ember-cli/package.json # yarn.lock
Issue: #5183
What I did
I reduced the version of
babel-loader
required by all the storybook subpackages to^8.0.0
instead of^8.2.2
so that modern versions ofreact-scripts
can resolve the version it wantsHow to test
One thing that we should test is the missing dependency I saw here: #5183 (comment)
Not sure why the particular dependency was missing but i can't find mention of
babel-plugin-polyfill-corejs2
in the storybook codebase, not really sure what was going on with that; maybe it was an addon?