Skip to content

Commit

Permalink
build(package): resolve build dependencies
Browse files Browse the repository at this point in the history
storybook has a conflict with cra due to versioning issues on babel loader and a faulty check on the
cra side (see: storybookjs/storybook#13183 and
facebook/create-react-app#10123 (comment)). this required either some hackery on the command side (by disabling preflight checks) or upgrading react-scripts to 5.0. as react scripts is not a direct dependency at runtime when serving our application, i opted for this approach.

another issue that cropped up was postcss requiring version 8 due to transistive dependencies (design system -> chakra -> tailwind -> postcss). this was fixed by installing a direct dependency on postcss @ 8, which was the approach mentioned here: postcss/postcss-import#435. A dev mentioned that the API between 7/8 did not differ much and the release notes for 8 (https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users) also mentioned that there are no significant differences for end users, so this should be safe.

tl;dr: build issues are fixed by upgrading dependencies.

if you ever read this message, or any of the previous long commit messages, please drop me a :ultrafastparrot: thx
  • Loading branch information
seaerchin committed Feb 18, 2022
1 parent f2c50c6 commit d03ad15
Show file tree
Hide file tree
Showing 2 changed files with 11,777 additions and 18,348 deletions.

0 comments on commit d03ad15

Please sign in to comment.