Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #122

Merged
merged 11 commits into from May 4, 2021
Merged

Upgrade dependencies #122

merged 11 commits into from May 4, 2021

Conversation

haworku
Copy link
Contributor

@haworku haworku commented May 3, 2021

Summary

  • Upgrade Storybook
  • Upgrade React Scripts
    • Used the migration guide. It's important to always look at the guide when updating bc react-scripts is infamous for causing problems on upgrade. Our upgrade did cause an error that stopped the app from building due to competing babel-loader versions with storybook. To resolve I manually pinned yarn.lock a level down for now. There is a documented bug in CRA and storybook for this.
    • new BUILD_PATH behavior is something we may want to take advantage of one day
  • Also went through app-web, app-api and the root app and ran yarn audit and yarn upgrade for any packages I could to try and clear out more dependabot errors.

Related issues

This is tech maintenance

Testing guidance

  • the app and storybook should still run locally. All tests should pass in CI

@haworku haworku requested a review from joshmfranklin May 3, 2021 15:52
@haworku haworku marked this pull request as draft May 3, 2021 15:53
@haworku haworku removed the request for review from joshmfranklin May 3, 2021 15:54
@haworku haworku marked this pull request as ready for review May 4, 2021 14:10
@haworku haworku requested a review from joshmfranklin May 4, 2021 14:10
Copy link
Contributor

@joshmfranklin joshmfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get the app and storybook up and running and all tests passing. Looks good!

@haworku haworku merged commit 97ed9df into main May 4, 2021
@haworku haworku deleted the hw-dependencies branch May 4, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants