Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Config client authentication exec command should not fail when args is null #4381

Merged
merged 2 commits into from Sep 22, 2022
Merged

fix: Config client authentication exec command should not fail when args is null #4381

merged 2 commits into from Sep 22, 2022

Conversation

sunix
Copy link
Collaborator

@sunix sunix commented Sep 2, 2022 •
edited by manusa

Description

Fix #3733
Closes #4121

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sunix sunix mentioned this pull request Sep 2, 2022
Closed
@sunix sunix force-pushed the fix-client-auth-command-with-null-args branch from 5b3f0bc to de32b96 Compare September 2, 2022 08:29
@rohanKanojia
Copy link
Member

test seems to be failing on windows (I suspect maybe it's due to a typo)

@sunix
Copy link
Collaborator Author

sunix commented Sep 2, 2022

test seems to be failing on windows (I suspect maybe it's due to a typo)

no ... it's just that there are 2 scripts, 1 .bat for win and 1 sh, they are not implemented in the same way

@sunix sunix force-pushed the fix-client-auth-command-with-null-args branch from de32b96 to bc4dfb4 Compare September 5, 2022 12:05
@rohanKanojia rohanKanojia added the changelog missing A line to changelog.md regarding the change is not added label Sep 8, 2022
@manusa manusa mentioned this pull request Sep 22, 2022
Closed
11 tasks
@manusa manusa force-pushed the fix-client-auth-command-with-null-args branch from bc4dfb4 to ba717e5 Compare September 22, 2022 10:45
@manusa manusa added 5.12.x Backportable tentative and removed changelog missing A line to changelog.md regarding the change is not added labels Sep 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.2.0 milestone Sep 22, 2022
@manusa manusa merged commit ec0aba8 into fabric8io:master Sep 22, 2022
This was referenced Sep 28, 2022
Closed
Merged
@manusa manusa removed the 5.12.x Backportable tentative label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@shawkins shawkins Awaiting requested review from shawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

Config execs wrong command when user.exec.args is null (as generated by kubectl config set-credentials)
4 participants
@sunix @rohanKanojia @manusa @markusheiden