Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not discard auth command if no args #4121

Closed

Conversation

markusheiden
Copy link
Contributor

@markusheiden markusheiden commented May 5, 2022

Description

The authentication command (user.exec.args: command) from the .kube/config won't be discarded if no arguments are specified (user.exec.args: null).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Fixes #3733
Backport for the 5.12 branch: #4122

@markusheiden
Copy link
Contributor Author

Due to problems in the master branch that are not related to this PR I was not able to test my code at all. How to progress?

@manusa
Copy link
Member

manusa commented May 11, 2022

Due to problems in the master branch that are not related to this PR I was not able to test my code at all. How to progress?

Could you please elaborate on the problems?

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@markusheiden
Copy link
Contributor Author

I tried again and it worked. Maybe I used the wrong JDK before.

@manusa
Copy link
Member

manusa commented Sep 22, 2022

This issue was also tackled on #4381, I'll merge some of the changes in this PR into the other one and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config execs wrong command when user.exec.args is null (as generated by kubectl config set-credentials)
2 participants