Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of #4381 #4455

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Backport of #4381 #4455

merged 2 commits into from
Sep 28, 2022

Conversation

manusa
Copy link
Member

@manusa manusa commented Sep 28, 2022

Description

Backport of #4381

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa mentioned this pull request Sep 28, 2022
Closed
11 tasks
@manusa manusa added this to the 5.12.4 milestone Sep 28, 2022
markusheiden and others added 2 commits September 28, 2022 12:40
@markusheiden @manusa
Do not discard auth command if no args
1b0662a 
(cherry picked from commit 0c19ce2)
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sunix @manusa
fix: Config client authentication exec command should not fail when a…
d8871c1 
…rgs is null

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

(cherry picked from commit ec0aba8)
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 6c5fd96 into fabric8io:5.12 Sep 28, 2022
@manusa manusa deleted the backport/4381 branch September 28, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.12.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manusa @oscerd @markusheiden @sunix