Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @rnc/datetimepicker@6.5.0 ➡️ @rnc/datetimepicker@6.5.2 #19642

Merged
merged 3 commits into from Oct 21, 2022

Conversation

byCedric
Copy link
Member

Why

A few bugfixes have landed, which might be nice to pick up in SDK 47 too.

How

Ran et update-vendored-module --module @react-native-community/datetimepicker --target expo-go --commit 70c594271c0c877b43533b09f95f60b768851344

See update output
 🧶 Yarning...
 🛠  Rebuilding expotools
 ✨ Successfully built expotools

📥 Cloning @react-native-community/datetimepicker#70c594271c0c877b43533b09f95f60b768851344 from https://github.com/react-native-community/react-native-datetimepicker.git
‼️  Using legacy vendoring for platform ios
NOTE: In Expo, native Android styles are prefixed with ReactAndroid. Please ensure that resourceNames used for grabbing style of dialogs are being resolved properly.

Cleaning up iOS files at Exponent/Versioned/Core/Api/Components/DateTimePicker ...

Copying iOS files ...
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePicker.h
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePicker.m
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerManager.h
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerManager.m
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerShadowView.h
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerShadowView.m

Updating pbxproj configuration ...
Saving updated pbxproj structure to the file Exponent.xcodeproj/project.pbxproj ...

Successfully updated iOS files, but please make sure Xcode project files are setup correctly in Exponent/Versioned/Core/Api/Components/DateTimePicker
‼️  Using legacy vendoring for platform android
NOTE: In Expo, native Android styles are prefixed with ReactAndroid. Please ensure that resourceNames used for grabbing style of dialogs are being resolved properly.

Cleaning up Android files at expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker ...

Copying Android files ...
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/Common.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/MinuteIntervalSnappableTimePickerDialog.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/ReflectionHelper.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNConstants.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDate.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDialogFragment.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDialogModule.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDisplay.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDateTimePickerPackage.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDismissableDatePickerDialog.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDismissableTimePickerDialog.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDialogFragment.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDialogModule.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDisplay.java
✍️  Updating bundled native modules
✍️  Updating workspace dependencies
💪 Successfully updated @react-native-community/datetimepicker

Test Plan

I believe there are only Android changes, so only need to test this on Android.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 20, 2022
@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 20, 2022
@byCedric byCedric force-pushed the @bycedric/datetimepicker/upgrade-to-6.5.2 branch from 7bd938d to e876765 Compare October 20, 2022 16:30
@expo-bot

This comment was marked as spam.

@byCedric

This comment was marked as resolved.

@byCedric
Copy link
Member Author

@tsapeta I'm going to merge this, even with the Android failure. Seems like this is happening on all PRs, and I'm pretty sure the Android stuff builds :) If it does cause trouble, ping me on Slack

@byCedric byCedric merged commit a199b20 into main Oct 21, 2022
@byCedric byCedric deleted the @bycedric/datetimepicker/upgrade-to-6.5.2 branch October 21, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants