Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @rnc/datetimepicker@6.5.0 ➡️ @rnc/datetimepicker@6.5.2 #19642

Merged
merged 3 commits into from Oct 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -24,6 +24,7 @@ Package-specific changes not released in any SDK will be added here just before
- Updated `@react-native-community/slider` from `4.2.3` to `4.2.4`. ([#19424](https://github.com/expo/expo/pull/19424)) by [@kudo](https://github.com/kudo))
- Updated `react-native-svg` from `12.3.0` to `13.4.0`. ([#19434](https://github.com/expo/expo/pull/19434) by [@lukmccall](https://github.com/lukmccall))
- Updated `react-native-reanimated` from `2.10.0` to `2.11.0`. ([#19602](https://github.com/expo/expo/pull/19602) by [@lukmccall](https://github.com/lukmccall))
- Updated `@react-native-community/datetimepicker` from `6.5.0` to `6.5.2`. ([#19642](https://github.com/expo/expo/pull/19642) by [@byCedric](https://github.com/byCedric))

### 🛠 Breaking changes

Expand Down
Expand Up @@ -34,6 +34,7 @@ public MinuteIntervalSnappableTimePickerDialog(
RNTimePickerDisplay display
) {
super(context, listener, hourOfDay, minute, is24HourView);
setCanceledOnTouchOutside(true);
mTimePickerInterval = minuteInterval;
mTimeSetListener = listener;
mDisplay = display;
Expand All @@ -51,6 +52,7 @@ public MinuteIntervalSnappableTimePickerDialog(
RNTimePickerDisplay display
) {
super(context, theme, listener, hourOfDay, minute, is24HourView);
setCanceledOnTouchOutside(true);
mTimePickerInterval = minuteInterval;
mTimeSetListener = listener;
mDisplay = display;
Expand Down
Expand Up @@ -40,6 +40,7 @@ public RNDismissableDatePickerDialog(
int dayOfMonth,
RNDatePickerDisplay display) {
super(context, callback, year, monthOfYear, dayOfMonth);
setCanceledOnTouchOutside(true);
fixSpinner(context, year, monthOfYear, dayOfMonth, display);
}

Expand All @@ -52,6 +53,7 @@ public RNDismissableDatePickerDialog(
int dayOfMonth,
RNDatePickerDisplay display) {
super(context, theme, callback, year, monthOfYear, dayOfMonth);
setCanceledOnTouchOutside(true);
fixSpinner(context, year, monthOfYear, dayOfMonth, display);
}

Expand Down
2 changes: 1 addition & 1 deletion apps/bare-expo/package.json
Expand Up @@ -92,7 +92,7 @@
"dependencies": {
"@babel/runtime": "^7.14.0",
"@react-native-async-storage/async-storage": "~1.17.3",
"@react-native-community/datetimepicker": "6.5.0",
"@react-native-community/datetimepicker": "6.5.2",
"@react-native-community/netinfo": "9.3.3",
"@react-native-community/slider": "4.2.4",
"@react-native-community/viewpager": "5.0.11",
Expand Down
2 changes: 1 addition & 1 deletion apps/native-component-list/package.json
Expand Up @@ -42,7 +42,7 @@
"dependencies": {
"@expo/react-native-action-sheet": "^3.8.0",
"@react-native-async-storage/async-storage": "~1.17.3",
"@react-native-community/datetimepicker": "6.5.0",
"@react-native-community/datetimepicker": "6.5.2",
"@react-native-community/netinfo": "9.3.3",
"@react-native-community/slider": "4.2.4",
"@react-native-masked-view/masked-view": "0.2.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/expo/bundledNativeModules.json
@@ -1,7 +1,7 @@
{
"@expo/vector-icons": "^13.0.0",
"@react-native-async-storage/async-storage": "~1.17.3",
"@react-native-community/datetimepicker": "6.5.0",
"@react-native-community/datetimepicker": "6.5.2",
"@react-native-masked-view/masked-view": "0.2.7",
"@react-native-community/netinfo": "9.3.3",
"@react-native-community/slider": "4.2.4",
Expand Down