Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored modules that were patched since last update #19647

Merged
merged 7 commits into from Oct 21, 2022

Conversation

brentvatne
Copy link
Member

@brentvatne brentvatne commented Oct 20, 2022

Why

There are some useful easy to pull patches that we can sneak in before versioning.

How

et uvm # etc..

Test Plan

Run examples in NCL

Checklist

@brentvatne brentvatne requested review from Kudo and removed request for ide and tsapeta October 20, 2022 22:50
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 20, 2022
@brentvatne brentvatne removed the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 20, 2022
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for walking through all the updates and creating this pr 🔥

CHANGELOG.md Outdated
@@ -7,6 +7,7 @@ Package-specific changes not released in any SDK will be added here just before

### 📚 3rd party library updates

- Updated `@react-native-community/netinfo` to `9.3.5`, `@react-native-picker/picker` to `2.4.8`, `@shopify/flash-list` to `1.3.1`, and `@shopify/react-native-skia` to `0.1.155` ([#19647](https://github.com/expo/expo/pull/19647) by [@brentvatne](https://github.com/brentvatne))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Cruzan told me to merge the changelog, so that users would be clear to see what versions we have, e.g.

- Updated `react-native-screens` from `3.4.0` to `3.8.0`. ([#14330](https://github.com/expo/expo/pull/14330) by [@cruzach](https://github.com/cruzach)) ([#14544](https://github.com/expo/expo/pull/14544) by [@kudo](https://github.com/kudo))

@brentvatne brentvatne merged commit 6476414 into main Oct 21, 2022
@brentvatne brentvatne deleted the @brent/update-vendored-deps branch October 21, 2022 18:01
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 1d1aac0

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants