chore: standardize npm script names #17431
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amareshsm
added
the
accepted
docs/package.json
Outdated
| "lint:fix:scss": "npm run lint:scss -- --fix" | ||
| "lint:scss": "stylelint \"**/*.{scss,html}\"", | ||
| "lint:fix:scss": "npm run lint:scss -- --fix", | ||
| "minify:images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'", |
There was a problem hiding this comment.
Maybe this should also be build?
| "minify:images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'", | |
| "build:images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'", |
There was a problem hiding this comment.
I feel like we could have it as minify:images only? or it could be build:images:minify?
There was a problem hiding this comment.
We can update it to build:minify-images ,WDYT?
|
Just as a reminder, we do have documentation about naming conventions for these scripts: |
I think we don't need to update anything on Netlify/Jenkins. Netlify only runs |
eslint-github-bot
bot
added
the
archived due to age
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Refers #14827
This updates the names of the scripts in package.json to be consistent with the new standard.
Is there anything you'd like reviewers to focus on?
Is there any script we need to update in Netlify/jenkins?