chore: standardize npm script names #461
Conversation
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
It seems that no changes should be made to the indent style.
The .editorconfig is used in eslint/eslint to apply 4 space indentation to all files. I think the eslint.org repository should be consistent as well, plus we could create a PR to add the missing .editorconfig file to it.
|
@snitin315 can you fix the spacing so that we can review the PR? |
|
Yeah, my editor automatically formatted the indentation. |
snitin315
force-pushed
the
chore/npm-scripts-standardize
branch
from
5a88c25
to
d09a425
Compare
| "build:sass:watch": "sass --watch src/assets/scss:src/assets/css", | ||
| "build:website": "npx @11ty/eleventy", | ||
| "build:website:watch": "cross-env IS_DEV=true eleventy --serve --port=2022", | ||
| "fetch": "npm-run-all --parallel fetch:*", |
There was a problem hiding this comment.
according to https://github.com/eslint/eslint/blob/main/docs/src/contribute/package-json-conventions.md we do not have any convention for fetch. May be we should consider adding it to the doc or replace these fetch with something like build:fetch?
There was a problem hiding this comment.
@mdjermanovic what do you think? I could live with adding a fetch: prefix.
Otherwise, maybe build:remote-data?
There was a problem hiding this comment.
If it can just add the fetch prefix, then that's better in my opinion.
There was a problem hiding this comment.
Adding new fetch: prefix sounds good to me.
build: = generates a set of files from local files only.
fetch: = Like build:, but includes fetching some data from remote locations.
There was a problem hiding this comment.
Aligned on introducing fetch: scripts. Lets add it to the contribute's package-json-convention also @snitin315
There was a problem hiding this comment.
I'll update the docs.
There was a problem hiding this comment.
LGTM. make sure to update https://github.com/eslint/eslint/blob/main/docs/src/contribute/package-json-conventions.md as we mentioned
Prerequisites checklist
What is the purpose of this pull request?
Refers eslint/eslint#14827
What changes did you make? (Give an overview)
This updates the names of the scripts in package.json to be consistent with the new standard.
Is there anything you'd like reviewers to focus on?
Is there any script we need to update on Netlify?