Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: standardize npm script names #17431

Merged
merged 2 commits into from Aug 7, 2023
Merged

chore: standardize npm script names #17431

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf6393
chore: standardize npm script names
snitin315 Jul 29, 2023
8c8a563
chore: use `build:minify-images` instead of `minify:images`
snitin315 Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions docs/package.json
View file
Open in desktop
Expand Up @@ -9,18 +9,18 @@
"license": "MIT",
"files": [],
"scripts": {
"images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'",
"watch:postcss": "postcss src/assets/css -d src/assets/css --watch --poll",
"watch:sass": "sass --watch --poll src/assets/scss:src/assets/css --no-source-map",
"watch:eleventy": "eleventy --serve --port=2023",
"build": "npm-run-all build:sass build:postcss build:website minify:images",
"build:postcss": "postcss src/assets/css -d src/assets/css",
"build:postcss:watch": "postcss src/assets/css -d src/assets/css --watch --poll",
"build:sass": "sass src/assets/scss:src/assets/css --no-source-map",
"build:eleventy": "npx @11ty/eleventy",
"start": "npm-run-all build:sass build:postcss --parallel watch:*",
"build": "npm-run-all build:sass build:postcss build:eleventy images",
"lint:scss": "stylelint \"**/*.{scss,html}\"",
"build:sass:watch": "sass --watch --poll src/assets/scss:src/assets/css --no-source-map",
"build:website": "npx @11ty/eleventy",
"build:website:watch": "eleventy --serve --port=2023",
"lint:links": "cross-env NODE_OPTIONS=--max-old-space-size=4096 node tools/validate-links.js",
"lint:fix:scss": "npm run lint:scss -- --fix"
"lint:scss": "stylelint \"**/*.{scss,html}\"",
"lint:fix:scss": "npm run lint:scss -- --fix",
"minify:images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should also be build?

Suggested change
"minify:images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'",
"build:images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we could have it as minify:images only? or it could be build:images:minify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update it to build:minify-images ,WDYT?

"start": "npm-run-all build:sass build:postcss --parallel *:*:watch"
},
"devDependencies": {
"@11ty/eleventy": "^1.0.1",
Expand Down