dialect/sql/schema: add name to versioned migration files #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseelch
changed the title
|
Hey @imhuytq, thank you your contribution. @all-contributors please add @imhuytq for code. |
|
I've put up a pull request to add @imhuytq! 🎉 |
zeevmoney
added a commit
to zeevmoney/ent
that referenced
this pull request
Mar 15, 2022
* master: doc/website/blog: versioned migrations (ent#2387) build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (ent#2386) go: upgrade atlas for tidb support (ent#2394) dialect/sql/schema: add method to create a named versioned migration … (ent#2385) docs: add maorlipchuk as a contributor for code (ent#2381) entc/gen: set Ref and Inverse for edge contains both From and To schema/field: expose RType.Implements method (ent#2379) docs: add imhuytq as a contributor for code (ent#2378) dialect/sql/schema: add name to versioned migration files (ent#2375) all: update atlasgo.io to latest (ent#2376) dialect/sql/schema: fix bug in atlas integration when working WithDropIndex/WithDropColumn (ent#2374) build(deps): bump actions/checkout from 2.4.0 to 3 (ent#2372) build(deps): bump actions/setup-node from 2.5.1 to 3 (ent#2365)
gitlawr
pushed a commit
to gitlawr/ent
that referenced
this pull request
Apr 13, 2022
* add name to versioned migration files * Skip writing migration files if the plan has no changes
gitlawr
pushed a commit
to seal-io/ent
that referenced
this pull request
Apr 13, 2022
* add name to versioned migration files * Skip writing migration files if the plan has no changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
golang-migratewill not be able to scan versioned migration files generated because the filename does not match this pattern: ^([0-9]+)_(.*).(down|up).(. *)$. So to satisfy the above pattern, we need to add names for the versioned migration files.Another thing is that we should not execute
Planner.WritePlanif there are no changes. Otherwise, it will generate empty migration files.