Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialect/sql/schema: add name to versioned migration files #2375

Merged
merged 3 commits into from Mar 7, 2022
Merged

dialect/sql/schema: add name to versioned migration files #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5815ce4
add name to versioned migration files
imhuytq Mar 4, 2022
bb7c9bc
Skip writing migration files if the plan has no changes
imhuytq Mar 4, 2022
0e6ee9e
Merge branch 'master' into versioned-migration-files-name
imhuytq Mar 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion dialect/sql/schema/atlas.go
View file
Open in desktop
Expand Up @@ -364,7 +364,7 @@ func (m *Migrate) atDiff(ctx context.Context, conn dialect.ExecQuerier, tables .
return nil, err
}
// Plan changes.
return drv.PlanChanges(ctx, "", changes)
return drv.PlanChanges(ctx, "changes", changes)
}

type db struct{ dialect.ExecQuerier }
Expand Down
4 changes: 4 additions & 0 deletions dialect/sql/schema/migrate.go
View file
Open in desktop
Expand Up @@ -171,6 +171,10 @@ func (m *Migrate) Diff(ctx context.Context, tables ...*Table) error {
if err != nil {
return err
}
// Skip if the plan has no changes
if len(plan.Changes) == 0 {
return nil
}
return migrate.NewPlanner(nil, m.atlas.dir, migrate.WithFormatter(m.atlas.fmt)).WritePlan(plan)
}

Expand Down