dialect/sql/schema: add name to versioned migration files (ent#2375)

* add name to versioned migration files * Skip writing migration files if the plan has no changes
seal-io · Apr 13, 2022 · 4ac163b · 4ac163b
1 parent 7066ca1
commit 4ac163b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/dialect/sql/schema/atlas.go b/dialect/sql/schema/atlas.go
@@ -364,7 +364,7 @@ func (m *Migrate) atDiff(ctx context.Context, conn dialect.ExecQuerier, tables .
 		return nil, err
 	}
 	// Plan changes.
-	return drv.PlanChanges(ctx, "", changes)
+	return drv.PlanChanges(ctx, "changes", changes)
 }
 
 type db struct{ dialect.ExecQuerier }

diff --git a/dialect/sql/schema/migrate.go b/dialect/sql/schema/migrate.go
@@ -171,6 +171,10 @@ func (m *Migrate) Diff(ctx context.Context, tables ...*Table) error {
 	if err != nil {
 		return err
 	}
+	// Skip if the plan has no changes
+	if len(plan.Changes) == 0 {
+		return nil
+	}
 	return migrate.NewPlanner(nil, m.atlas.dir, migrate.WithFormatter(m.atlas.fmt)).WritePlan(plan)
 }