[CLEANUP] Remove jQuery integration in EventDispatcher

[simonihmig]

Reopened #19552

[mixonic]

Can we assert the presence of event here and event instanceof Event or something?

I believe these two comments apply across the rest of this file and some other files. In the test which isn't for deprecated behavior, please assert the event argument is passed.

[simonihmig]

Not only does this totally make sense, but trying to add that assertion uncovered an actual bug, as the event passed was a jQuery event. 😱

The internal components seem do use some additional jQuery related magic, that I was not aware of:

ember.js/packages/@ember/-internals/glimmer/lib/components/internal.ts

Lines 556 to 576 in 3ce13ce

	export function jQueryEventShim(target: DeprecatingInternalComponentConstructor): void {
	if (JQUERY_INTEGRATION) {
	let { prototype } = target;
	let superListenerFor = prototype['listenerFor'];
	Object.defineProperty(prototype, 'listenerFor', {
	configurable: true,
	enumerable: false,
	value: function listenerFor(this: InternalComponent, name: string): EventListener {
	let listener = superListenerFor.call(this, name);
	if (jQuery && !jQueryDisabled) {
	return (event: Event) => listener(new jQuery.Event(event));
	} else {
	return listener;
	}
	},
	});
	}
	}

So this will need some more cleanup...

[rwjblue]

FYI - I moved this into draft so I can keep track of where review is needed vs where more work is in progress, please move back out of draft when its ready to review again.

[simonihmig]

Pushed an update:

• rebased
• added back assertions for (native) events (addressing [CLEANUP] Remove jQuery integration in EventDispatcher #19666 (comment))
• removed jQueryEventShim

Note: there are still a few jQuery-related leftovers, like the deprecated feature flag, which are not directly related to the narrower scope of this PR, and which I plan to address in a follow-up PR when this is merged.