Deprecation Cleanup for 4.0 #19617

kategengler · 2021-07-02T19:59:43Z

PLEASE FLAG REMOVAL/CLEANUP PRs WITH [CLEANUP beta] IN THE PR TITLE.

The following are the deprecations in ember.js that are until 4.0 or earlier. Each item includes the id of the deprecation in backticks. Searching for this id in the source will find the invocations of that deprecation.

Remaining

[CLEANUP beta] Make using the "classic" edition of Ember throw #19846 - Optional feature: application-template-wrapper

ember.js/lib/index.js

Line 131 in 5a36048

    
           'Setting the `application-template-wrapper` optional feature flag to `true`, or not providing a setting at all, has been deprecated. You must add the `@ember/optional-features` addon and set this feature to `false`. You can also run `npx @ember/octanify` to do this. This warning will become an error in Ember 4.0.0.\n\nFor more information, see the deprecation guide: https://deprecations.emberjs.com/v3.x/#toc_optional-feature-application-template-wrapper'

[CLEANUP beta] Make using the "classic" edition of Ember throw #19846 - Optional feature: Unspecified or specified classic edition

ember.js/lib/index.js

Line 123 in 5a36048

    
           'The Ember Classic edition has been deprecated. Specifying "classic" in your package.json, or not specifying a value at all, will no longer be supported. You must explicitly set the "ember.edition" property to "octane". This warning will become an error in Ember 4.0.0.\n\nFor more information, see the deprecation guide: https://deprecations.emberjs.com/v3.x/#toc_editions-classic'

[CLEANUP beta] Remove check to see if ember is defined as a Bower dependency #19838 - Change bower usage to a throw instead of warn at

ember.js/lib/index.js

Line 47 in ce98e57

// TODO: move this to a throw soon.

[CLEANUP beta] Turn template-only-glimmer-components deprecation into an error #19836 - Optional feature: template-only-glimmer-components

ember.js/lib/index.js

Line 140 in 5a36048

    
           'Setting the `template-only-glimmer-components` optional feature flag to `false`, or not providing a setting at all, has been deprecated. You must add the `@ember/optional-features` addon and set this feature to `true`. You can also run `npx @ember/octanify` to do this. This warning will become an error in Ember 4.0.0.\n\nFor more information, see the deprecation guide: https://deprecations.emberjs.com/v3.x/#toc_optional-feature-template-only-glimmer-components'

[CLEANUP beta] Remove deprecated array observers #19833 Array Observers array-observers Deprecation Guide Deprecation Invocation Site + 1 other in same file
Ember.Component.reopen ember.component.reopenDeprecation Guide Deprecation Invocation Site see also [DOC beta] Deprecation link for Ember.Component.reopen #19744 (comment)
[CLEANUP beta] Update GlimmerVM to 0.81 #19762 - Component manager capabilities prior to 3.13 manager-capabilities.components-3-4 Deprecation Guide Deprecation Invocation Site
[CLEANUP beta] Update GlimmerVM to 0.81 #19762 - Modifier manager capabilities prior to 3.22 manager-capabilities.modifiers-3-13 Deprecation Guide Deprecation Invocation Site
[CLEANUP beta] Remove deprecate-router-events support code #19749 - Router Events deprecate-router-events Deprecation Guide Deprecation Invocation Site + a few other locations

VM Deprecations

[CLEANUP beta] Inelegant throw for arg-less-paren-less helper #19843 - Helper invocations without arguments or parens argument-less-helper-paren-less-invocation Deprecation Guide Deprecation Invocation Site: (1/2)
[CLEANUP beta] Update GlimmerVM to 0.81 #19762 - Mutation after consumption autotracking.mutation-after-consumption Deprecation Invocation Site
[CLEANUP beta] Update GlimmerVM to 0.81 #19762 - this. property fallback this-property-fallback Deprecation Guide Deprecation Invocation Site

🔒 Built-in Components

All should be 🔒 in #19806

Remove LinkTo's tagName #19662 - Passing tagName to LinkTo ember.link-to.tag-name Deprecation Guide Deprecation Invocation Site
Importing legacy built-in components ember.built-in-components.import Deprecation Guide Deprecation Invocation Site + other locations
Legacy Attributes to built-in Components ember.built-in-components.legacy-attribute-arguments Deprecation Guide Deprecation Invocation Site + 2 more in the same file
Legacy Arguments to built-in Components ember.built-in-components.legacy-arguments Deprecation Guide Deprecation Invocation Site + several more
Remove Reopening Built In Components #19664 - Reopening Built In Components ember.built-in-components.reopen Deprecation Guide Deprecation Invocation Site + several more
LinkTo Positional Arguments ember-glimmer.link-to.positional-arguments Deprecation Guide Deprecation Invocation Site + other locations
🔒 Remove deprecated disabledWhen #19669 (NOTE: This PR was merged and reverted) - Passing disabledWhen to LinkTo ember.link-to.disabled-when Deprecation Guide Deprecation Invocation Site + 1 more in the same file

Completed

The text was updated successfully, but these errors were encountered:

sandstrom · 2021-07-04T15:04:30Z

What do you think about deprecating Auto Location, is that something you'd like to get in before 4.0?

#19510

It's a fairly low-impact deprecation, in that the change required is a one-line change in the config. More details in that PR and the associated RFC.

But there is also no real rush, deprecating it doesn't "unlock" any new functionality, so could also wait until after 4.0 with merging it.

kategengler · 2021-07-04T15:10:42Z

@sandstrom This is a list of already deprecated APIs that need to be removed for 4.0. At this point, the master branch is already 4.0, and so no newly added deprecations will make it into 3.x.

nlfurniss · 2021-07-13T22:01:03Z

IE11 was removed in #19558

Part of emberjs#19617

snewcomer · 2021-07-25T12:40:05Z

I can take this one since I did the original PR!

Implicit Injections implicit-injections

snewcomer · 2021-09-03T15:14:09Z

I understand we are all busy. It is commendable even finding time to track issues, review and contribute code in our spare time. But is there any urgency to get this issue across the line in the coming weeks or is there an often talked about timeline not publicized? I have a few PRs open in glimmer that need review and would be happy to help with any remaining ones (once this tracking checkboxes are updated with where we are at).

kategengler · 2021-09-04T01:28:11Z

There's definitely some urgency. 4.0 is the next release and ideally we would have gotten this all done before it even branched to beta.

Participation definitely drops over the summer and a few have commented that in the future we should avoid summer for major release pushes. We probably need to find a way to not have time-bound work for major releases.

nlfurniss · 2021-10-21T08:03:02Z

Both Component manager capabilities prior to 3.13 and Modifier manager capabilities prior to 3.22 are covered by #19762

xg-wang · 2021-10-21T16:09:31Z

deprecate-router-events is covered by #19749 and ready for review

Part of emberjs#19617 * Remove `someArray.addArrayObserver` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L532 * Remove `someArray.removeArrayObserver` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L548 * Remove `someArray.hasArrayObservers` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L571 * Remove `someArray.arrayContentWillChange` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L642 * Remove `someArray.arrayContentDidChange` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L670 (also at https://github.com/emberjs/ember.js/pull/19833/files#diff-79a0015ca0e6a6c3661d9119f4caf6b26b111af6bb0e5bb784558631c599a81cL357) * On the internal version of `addArrayObserver`, remove the optionality of `willChange` and `didChange` arguments to name the hooks. In framework code (and now in test) these are always provided. * Retain basically all the test coverage of array observers since they remain used by `ArrayProxy` internally (and through that interface, in Ember Data). Co-authored-by: Matthew Beale <matt.beale@madhatted.com>

Part of #19617 * Remove `someArray.addArrayObserver` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L532 * Remove `someArray.removeArrayObserver` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L548 * Remove `someArray.hasArrayObservers` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L571 * Remove `someArray.arrayContentWillChange` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L642 * Remove `someArray.arrayContentDidChange` https://github.com/emberjs/ember.js/pull/19833/files#diff-8116921433c6e1664250d5735e4f9daeb6ea9e00940783e0c4db7adf88aa8772L670 (also at https://github.com/emberjs/ember.js/pull/19833/files#diff-79a0015ca0e6a6c3661d9119f4caf6b26b111af6bb0e5bb784558631c599a81cL357) * On the internal version of `addArrayObserver`, remove the optionality of `willChange` and `didChange` arguments to name the hooks. In framework code (and now in test) these are always provided. * Retain basically all the test coverage of array observers since they remain used by `ArrayProxy` internally (and through that interface, in Ember Data). Co-authored-by: Matthew Beale <matt.beale@madhatted.com> (cherry picked from commit a9aedea)

kategengler · 2021-11-15T18:11:10Z

This is done! Thank you to everybody who participated in deprecation removal <3

kategengler mentioned this issue Jul 2, 2021

Ember 4.0 Tracking Issue #19545

Closed

19 tasks

This was referenced Jul 13, 2021

Remove deprecated getWithDefault for v4.0 #19620

Closed

Remove deprecated Ember.merge for v4.0 #19621

Closed

Remove deprecated getWithDefault for v4.0 #19622

Closed

Remove deprecated tryInvoke for v4.0 #19623

Closed

mixonic added a commit to mixonic/ember.js that referenced this issue Jul 18, 2021

Remove copy & Copyable

b9a0353

Part of emberjs#19617

mixonic mentioned this issue Jul 18, 2021

Remove copy & Copyable #19636

Merged

mixonic added a commit to mixonic/ember.js that referenced this issue Jul 18, 2021

Remove copy & Copyable

041f260

Part of emberjs#19617

mixonic added a commit to mixonic/ember.js that referenced this issue Jul 18, 2021

Remove copy & Copyable

e3b80e4

Part of emberjs#19617

mixonic added a commit to mixonic/ember.js that referenced this issue Jul 18, 2021

Remove copy & Copyable

61b6237

Part of emberjs#19617

mixonic added a commit to mixonic/ember.js that referenced this issue Jul 18, 2021

Remove copy & Copyable

f6cb99e

Part of emberjs#19617

nlfurniss mentioned this issue Jul 18, 2021

Remove deprecated with #19638

Merged

MelSumner added the Ember 4.0 label Jul 23, 2021

snewcomer mentioned this issue Jul 25, 2021

[CLEANUP beta] Deprecate owner.inject #19680

Merged

5 tasks

mixonic mentioned this issue Aug 4, 2021

Remove {{partial}} #19695

Merged

This was referenced Aug 20, 2021

[CLEANUP beta] Remove template-compiler.registerPlugin #19704

Merged

[CLEANUP beta] Remove class-binding-and-class-name-bindings-in-templates #19708

Merged

[CLEANUP beta] Remove manager-capabilities deprecations #19731

Merged

jenweber mentioned this issue Sep 17, 2021

[DOC release-3-28] Add missing deprecation urls #19754

Closed

mixonic mentioned this issue Nov 4, 2021

[CLEANUP beta] Drop export of built-ins, remove legacy components #19806

Merged

SergeAstapov mentioned this issue Nov 9, 2021

[CLEANUP beta] Remove Ember.Component.reopen #19831

Closed

This was referenced Nov 11, 2021

[CLEANUP beta] remove addArrayObserver #19746

Closed

[CLEANUP beta] Remove deprecated array observers #19833

Merged

mixonic mentioned this issue Nov 14, 2021

[CLEANUP beta] Inelegant throw for arg-less-paren-less helper #19843

Merged

kategengler mentioned this issue Nov 15, 2021

[CLEANUP beta] Make using the "classic" edition of Ember throw #19846

Merged

kategengler closed this as completed Nov 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecation Cleanup for 4.0 #19617

Deprecation Cleanup for 4.0 #19617

kategengler commented Jul 2, 2021 •

edited

sandstrom commented Jul 4, 2021

kategengler commented Jul 4, 2021

nlfurniss commented Jul 13, 2021

snewcomer commented Jul 25, 2021

snewcomer commented Sep 3, 2021

kategengler commented Sep 4, 2021

nlfurniss commented Oct 21, 2021

xg-wang commented Oct 21, 2021

kategengler commented Nov 15, 2021

Deprecation Cleanup for 4.0 #19617

Deprecation Cleanup for 4.0 #19617

Comments

kategengler commented Jul 2, 2021 • edited

Remaining

VM Deprecations

🔒 Built-in Components

Completed

sandstrom commented Jul 4, 2021

kategengler commented Jul 4, 2021

nlfurniss commented Jul 13, 2021

snewcomer commented Jul 25, 2021

snewcomer commented Sep 3, 2021

kategengler commented Sep 4, 2021

nlfurniss commented Oct 21, 2021

xg-wang commented Oct 21, 2021

kategengler commented Nov 15, 2021

kategengler commented Jul 2, 2021 •

edited