[CLEANUP beta] Remove internal jQuery usage #19676
Conversation
simonihmig
force-pushed
the
jquery-cleanup
branch
from
f5394c4
to
883137a
Compare
simonihmig
force-pushed
the
jquery-cleanup
branch
from
883137a
to
3e4d387
Compare
|
@mixonic rebased and ready for review |
| librariesRegistered = true; | ||
|
|
||
| if (JQUERY_INTEGRATION && hasDOM && !jQueryDisabled) { | ||
| libraries.registerCoreLibrary('jQuery', jQuery().jquery); |
There was a problem hiding this comment.
Slightly unrelated, but is libraries really used for anything after this removal? I don't think it is.
There was a problem hiding this comment.
Hm, you mean the whole libraries thing, or just the import here? The import is used here for logging the Ember and possibly other registered addon versions to the console. And for that libraries.register() is still used in addons (I am using it here for example, but this reminds me I actually have to refactor this to not use the Ember global!) and ember-data itself. So I think this has to stay!?
mixonic
changed the title
|
@kategengler note, I belatedly updated the title here to include |
|
👍 As long as it is a recent merged and title is changed before the next beta, I'll catch any updated tags. I look through both commits & PRs due to inconsistency. |
Removes leftover internal jQuery references, and
JQUERY_INTEGRATIONandjQueryDisabledflags.Should be passing once #19666 and #19675 (or some other PR that removes usage ofjQueryDisabledfromember-testing) have landed.