Add Windows and macOS CI testing. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
add-windows-ci
branch
5 times, most recently
from
2ea09ad
to
d1ce04c
Compare
rwjblue
force-pushed
the
add-windows-ci
branch
from
d1ce04c
to
ee4680d
Compare
globby _always_ returns posix style paths (regardless of platform). In order to search for the "file with the error" in the output, we need to convert the `path.join` result into posix style paths. We (and globby) use `slash` for this in other areas, so it is used here for simplicity and to match the logic globby would use.
rwjblue
force-pushed
the
add-windows-ci
branch
from
1fd1066
to
d845e13
Compare
rwjblue
added
enhancement
rwjblue
changed the title
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes needed to move forward:
child_process.spawnin tests Useexecainstead ofchild_process.spawnin tests. #145ember-template-recastbin script file selection for Windows users #147gitignoreandabsoluteoptions at the same time on Windows sindresorhus/globby#137)