Skip to content

Commit

Permalink
Use posix paths with patterns passed to globby.
Browse files Browse the repository at this point in the history
globby uses the fast-glob package, which states this in its README (RE:
patterns):

> ⚠️ Always use forward-slashes in glob expressions (patterns and ignore
> option). Use backslashes for escaping characters.

Previously, we were using `path.join` which will use the OS specific
separator and therefore fail to match files when invoked with a
directory path directly.
  • Loading branch information
rwjblue committed Oct 16, 2019
1 parent 389a1d9 commit 2ea09ad
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/runner.js
@@ -1,7 +1,8 @@
const http = require('http');
const https = require('https');
const { writeFileSync } = require('fs');
const { resolve, extname, join } = require('path');
const { join } = require('path').posix;
const { resolve, extname } = require('path');
const colors = require('colors/safe');
const globby = require('globby');
const ora = require('ora');
Expand Down

0 comments on commit 2ea09ad

Please sign in to comment.