Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows and macOS CI testing. #143

Merged
merged 2 commits into from Oct 16, 2019
Merged

Add Windows and macOS CI testing. #143

merged 2 commits into from Oct 16, 2019

Commits on Oct 16, 2019

  1. Add Windows and macOS testing.

    @rwjblue
    rwjblue committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    ee4680d View commit details
    Browse the repository at this point in the history

  2. Refactor test assertion to be platform agnostic. 

    globby _always_ returns posix style paths (regardless of platform).
In order to search for the "file with the error" in the output, we need
to convert the `path.join` result into posix style paths. We (and
globby) use `slash` for this in other areas, so it is used here for
simplicity and to match the logic globby would use.
    @rwjblue
    rwjblue committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d845e13 View commit details
    Browse the repository at this point in the history