[ENHANCEMENT] Add template tag setup to ember new for apps
#10447
Conversation
IgnaceMaes
changed the title
ember new for appsember new for apps
| }, | ||
| },<% if (templateTag) { %> | ||
| // Template tag files | ||
| { |
There was a problem hiding this comment.
to do this we need to move everything out of the root-object of the .eslintrc and move everything to overrides because we can't have top-level parsers: https://github.com/ember-cli/ember-cli/pull/10447/files#diff-042c163c37338253d4a1cc6bf038fb8b4b45eebef94ebbd439a81c38b158dcb6R5
parsers can't be overridden by overrides, and lead to really weird hard to trace errors when you try
There was a problem hiding this comment.
| { | ||
| // test files | ||
| files: ['tests/**/*-test.{js,ts}'], | ||
| files: ['tests/**/*-test.{js,ts<% if (templateTag) { %>,gjs,gts<% } %>}'], |
There was a problem hiding this comment.
no need for if statement (imo, obvs, but strongly), this should just be in the default.
| @@ -89,17 +89,19 @@ | |||
| "ember-page-title": "^8.2.0", | |||
| "ember-qunit": "^8.0.2", | |||
| "ember-resolver": "^11.0.1", | |||
| "ember-source": "~5.7.0-beta.1", | |||
| "ember-source": "~5.7.0-beta.1<% if (templateTag) { %>", | |||
| "ember-template-imports": "^4.1.0<% } %>", | |||
There was a problem hiding this comment.
I don't think we can include ember-template-imports, specifically, until this is resolved: ember-template-imports/ember-template-imports#228
Adds setting up template tag dependencies for new Ember apps. (dependencies, configs)
Open question:
typescriptis enabled or not, making this complexer.Related: emberjs/tracking-polaris#33