-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Add template tag setup to ember new
for apps
#10447
base: master
Are you sure you want to change the base?
Changes from all commits
5f1e19d
41c5397
5f78714
73628a3
6024120
adfc429
23a503e
b3414e1
2c6636b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,10 +57,32 @@ module.exports = { | |
node: true, | ||
}, | ||
extends: ['plugin:n/recommended'], | ||
}, | ||
},<% if (templateTag) { %> | ||
// Template tag files | ||
{ | ||
files: ['**/*.gjs'], | ||
parser: 'ember-eslint-parser', | ||
plugins: ['ember'], | ||
extends: [ | ||
'eslint:recommended', | ||
'plugin:ember/recommended', | ||
'plugin:ember/recommended-gjs', | ||
], | ||
},<% if (typescript) { %> | ||
{ | ||
files: ['**/*.gts'], | ||
parser: 'ember-eslint-parser', | ||
plugins: ['ember'], | ||
extends: [ | ||
'eslint:recommended', | ||
'plugin:@typescript-eslint/recommended', | ||
'plugin:ember/recommended', | ||
'plugin:ember/recommended-gts', | ||
], | ||
},<% } %><% } %> | ||
{ | ||
// test files | ||
files: ['tests/**/*-test.{js,ts}'], | ||
files: ['tests/**/*-test.{js,ts<% if (templateTag) { %>,gjs,gts<% } %>}'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need for if statement (imo, obvs, but strongly), this should just be in the default. |
||
extends: ['plugin:qunit/recommended'], | ||
}, | ||
], | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,17 +89,19 @@ | |
"ember-page-title": "^8.2.0", | ||
"ember-qunit": "^8.0.2", | ||
"ember-resolver": "^11.0.1", | ||
"ember-source": "~5.7.0-beta.1", | ||
"ember-source": "~5.7.0-beta.1<% if (templateTag) { %>", | ||
"ember-template-imports": "^4.1.0<% } %>", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we can include |
||
"ember-template-lint": "^5.13.0<% if (welcome) { %>", | ||
"ember-welcome-page": "^7.0.2<% } %>", | ||
"eslint": "^8.56.0", | ||
"eslint-config-prettier": "^9.1.0", | ||
"eslint-plugin-ember": "^11.12.0", | ||
"eslint-plugin-ember": "^12.0.2", | ||
"eslint-plugin-n": "^16.6.2", | ||
"eslint-plugin-prettier": "^5.1.3", | ||
"eslint-plugin-qunit": "^8.0.1", | ||
"loader.js": "^4.7.0", | ||
"prettier": "^3.2.4", | ||
"prettier": "^3.2.4<% if (templateTag) { %>", | ||
"prettier-plugin-ember-template-tag": "^2.0.0<% } %>", | ||
"qunit": "^2.20.0", | ||
"qunit-dom": "^2.0.0", | ||
"stylelint": "^15.11.0", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to do this we need to move everything out of the root-object of the .eslintrc and move everything to overrides because we can't have top-level parsers: https://github.com/ember-cli/ember-cli/pull/10447/files#diff-042c163c37338253d4a1cc6bf038fb8b4b45eebef94ebbd439a81c38b158dcb6R5
parsers can't be overridden by overrides, and lead to really weird hard to trace errors when you try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs